Revert of My take on SkAlign changes.

include/core/SkTypes.h

 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkTypes_DEFINED
 #define SkTypes_DEFINED
 
@@ skipping 314 matching lines @@
 // Can be used to bracket data types that must be dense, e.g. hash keys.
 #if defined(__clang__)  // This should work on GCC too, but GCC diagnostic pop didn't seem to work!
     #define SK_BEGIN_REQUIRE_DENSE _Pragma("GCC diagnostic push") \
                                    _Pragma("GCC diagnostic error \"-Wpadded\"")
     #define SK_END_REQUIRE_DENSE   _Pragma("GCC diagnostic pop")
 #else
     #define SK_BEGIN_REQUIRE_DENSE
     #define SK_END_REQUIRE_DENSE
 #endif
 
-template <int N, typename T>
-struct SkAlign_traits {
-    static_assert (N > 0 && (N & (N-1)) == 0, "N must be a positive power of 2.");
-    constexpr static int Lg(int k) { return (k == 1) ? 0 : 1 + Lg(k/2); }
+#define SkAlign2(x)     (((x) + 1) >> 1 << 1)
+#define SkIsAlign2(x)   (0 == ((x) & 1))
 
-    constexpr static T Align(T x) { return (x + N-1) >> Lg(N) << Lg(N); }
-    constexpr static bool IsAligned(T x) { return 0 == (x & (N-1)); }
-};
+#define SkAlign4(x)     (((x) + 3) >> 2 << 2)
+#define SkIsAlign4(x)   (0 == ((x) & 3))
 
-template <int N, typename P>
-struct SkAlign_traits<N, P*> {
-    constexpr static P* Align(P* p) {
-        return (P*)SkAlign_traits<N, uintptr_t>::Align((uintptr_t)p);
-    }
-    constexpr static bool IsAligned(P* p) {
-        return SkAlign_traits<N, uintptr_t>::IsAligned((uintptr_t)p);
-    }
-};
+#define SkAlign8(x)     (((x) + 7) >> 3 << 3)
+#define SkIsAlign8(x)   (0 == ((x) & 7))
 
-template <int N, typename T>
-constexpr static inline T SkAlign(T x) { return SkAlign_traits<N,T>::Align(x); }
+#define SkAlign16(x)     (((x) + 15) >> 4 << 4)
+#define SkIsAlign16(x)   (0 == ((x) & 15))
 
-template <int N, typename T>
-constexpr static bool SkIsAligned(T x) { return SkAlign_traits<N,T>::IsAligned(x); }
-
-#define SkAlign2(x)     SkAlign<2>(x)
-#define SkIsAlign2(x)   SkIsAligned<2>(x)
-
-#define SkAlign4(x)     SkAlign<4>(x)
-#define SkIsAlign4(x)   SkIsAligned<4>(x)
-
-#define SkAlign8(x)     SkAlign<8>(x)
-#define SkIsAlign8(x)   SkIsAligned<8>(x)
-
-#define SkAlign16(x)     SkAlign<16>(x)
-#define SkIsAlign16(x)   SkIsAligned<16>(x)
-
-#define SkAlignPtr(x)   SkAlign<sizeof(void*)>(x)
-#define SkIsAlignPtr(x) SkIsAligned<sizeof(void*)>(x)
+#define SkAlignPtr(x)   (sizeof(void*) == 8 ?   SkAlign8(x) :   SkAlign4(x))
+#define SkIsAlignPtr(x) (sizeof(void*) == 8 ? SkIsAlign8(x) : SkIsAlign4(x))
 
 typedef uint32_t SkFourByteTag;
 #define SkSetFourByteTag(a, b, c, d)    (((a) << 24) | ((b) << 16) | ((c) << 8) | (d))
 
 /** 32 bit integer to hold a unicode value
 */
 typedef int32_t SkUnichar;
 
 /** 16 bit unsigned integer to hold a glyph index
 */
@@ skipping 362 matching lines @@
 
     void*       fPtr;
     size_t      fSize;  // can be larger than the requested size (see kReuse)
     uint32_t    fStorage[kSize >> 2];
 };
 // Can't guard the constructor because it's a template class.
 
 #endif /* C++ */
 
 #endif