Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Issue 237203003: Revert 263625 "Set the default ASan options for executables buil..." (Closed)

Created:
6 years, 8 months ago by Ami GONE FROM CHROMIUM
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 263625 "Set the default ASan options for executables buil..." Reason for revert: broke all 3 Linux ASan LSan Tests bots: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/1338 http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/1563 http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/1796 > Set the default ASan options for executables built with ASan on Linux. > > This is a copy of https://codereview.chromium.org/201153007 and https://codereview.chromium.org/213113002 > updated to the current trunk with more descriptive comments in sanitizer_options.cc and the additional > legacy_pthread_cond=1 option for the Linux builds. > > This CL introduces a module, base/debug/sanitizer_options.cc, which will override > the defaults for various dynamic tools (only ASan at this moment). For every executable > built with a dynamic tool this module will be linked into that executable, providing > weak functions to be called by the tool. > > The existing declaration of __asan_default_options() in chrome/app/chrome_exe_main_gtk.cc > has been moved into sanitizer_options.cc (now every binary built with GOOGLE_CHROME_BUILD=1 > will have the same options as google-chrome-asan. > The existing declaration of __asan_default_options() in chrome/nacl/nacl_helper_linux.cc > has been kept as is, but we had to remove -Wl,-u_sanitizer_options_link_helper to avoid picking sanitizer_options.cc. > > The default options target is deliberately disabled on 32-bit Chromium OS builds, where one of the host binaries (mksnapshot.ia32) is 32-bit despite host_arch==x86_64. > > GYP changes for OSX and iOS will be committed separately. > > BUG=302040, 341805 > TBR=thakis@chromium.org,mseaborn@chromium.org > > Review URL: https://codereview.chromium.org/230263003 TBR=glider@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -100 lines) Patch
M trunk/src/base/base.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D trunk/src/base/debug/sanitizer_options.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M trunk/src/build/common.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M trunk/src/components/nacl.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ami GONE FROM CHROMIUM
6 years, 8 months ago (2014-04-14 15:54:07 UTC) #1
Ami GONE FROM CHROMIUM
6 years, 8 months ago (2014-04-14 15:54:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r263634 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698