Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 213113002: Add the host toolset to base:sanitizer_options. Fix a typo in nacl.gyp (Closed)

Created:
6 years, 9 months ago by Alexander Potapenko
Modified:
6 years, 9 months ago
Reviewers:
Mark Seaborn, Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Add the host toolset to base:sanitizer_options. Fix a typo in nacl.gyp This is a follow-up for https://codereview.chromium.org/201153007/ intended to fix the ChromeOS ASan bots. BUG=302040 R=thakis@chromium.org TBR=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M base/base.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M components/nacl.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Alexander Potapenko
Please take a look.
6 years, 9 months ago (2014-03-26 16:11:02 UTC) #1
Nico
lgtm
6 years, 9 months ago (2014-03-26 16:17:25 UTC) #2
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 9 months ago (2014-03-26 16:25:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/213113002/1
6 years, 9 months ago (2014-03-26 16:25:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 17:05:40 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=57562
6 years, 9 months ago (2014-03-26 17:05:40 UTC) #6
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 9 months ago (2014-03-26 17:09:29 UTC) #7
Alexander Potapenko
On 2014/03/26 17:05:40, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 9 months ago (2014-03-26 17:09:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/213113002/1
6 years, 9 months ago (2014-03-26 17:11:33 UTC) #9
Mark Seaborn
LGTM for nacl.gyp
6 years, 9 months ago (2014-03-26 17:19:20 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 22:04:27 UTC) #11
Message was sent while issue was closed.
Change committed as 259709

Powered by Google App Engine
This is Rietveld 408576698