src/crankshaft/hydrogen.cc - Issue 2371963002: [crankshaft] TypedArrayInitialize: force length to be a Smi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2371963002: [crankshaft] TypedArrayInitialize: force length to be a Smi (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index 00b667376a8247460526087fec984c12156e0349..a450b2404809a92d46daca12445340f29e712e42 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -10273,6 +10273,8 @@ void HOptimizedGraphBuilder::GenerateTypedArrayInitialize(

HInstruction* length = AddUncasted<HDiv>(byte_length,

Add<HConstant>(static_cast<int32_t>(element_size)));

+ // Callers (in typedarray.js) ensure that length <= %_MaxSmi().

+ length = AddUncasted<HForceRepresentation>(length, Representation::Smi());

Add<HStoreNamedField>(obj,

HObjectAccess::ForJSTypedArrayLength(),

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-650404.js » ('j') | no next file with comments »