Remove |certificate_error_code| and SpdySession::TryAccessStream().

Remove |certificate_error_code| and SpdySession::TryAccessStream().

SpdySessionPool::CreateAvailableSessionFromSocket() is always called with a
hardcoded OK value for its |certificate_error_code| argument, so this can be
removed.  SpdySession::InitializeWithSocket() is only called from
SpdySessionPool::CreateAvailableSessionFromSocket() with |certificate_error_code
== OK|, so that argument can be removed as well.  Then
SpdySession::certificate_error_code_ member is always OK, so that can be removed
as well.  This makes SpdySession::TryAccessStream() always return OK, so that
can also be removed.

Metrics show that
SpdyProtocolErrorDetails::PROTOCOL_ERROR_REQUEST_FOR_SECURE_CONTENT_OVER_INSECURE_SESSION
is almost never (1e-11 of all counts) logged in Net.SpdySessionErrorDetails2.

BUG=624073
Committed: https://crrev.com/2c06a30cf92373b0cb4b721a4a8dac6d72635b93
Cr-Commit-Position: refs/heads/master@{#421250}

[Bence, 2016-09-27 14:14:05]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 14:14:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 16:21:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 16:21:44]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-09-27 16:35:43]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2016-09-27 16:35:43]

Ryan: PTAL.  Thank you.

[Ryan Hamilton, 2016-09-27 17:17:51]

lgtm

nice sleuthing!

https://codereview.chromium.org/2371943003/diff/1/net/spdy/spdy_session.h
File net/spdy/spdy_session.h (left):

https://codereview.chromium.org/2371943003/diff/1/net/spdy/spdy_session.h#old...
net/spdy/spdy_session.h:337: // ERR_IO_PENDING.
OH! I'll bet this is a hold-over from the days when we could do spdy for http
urls even if the cert didn't validate.

[Bence, 2016-09-27 17:23:33]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-09-27 17:23:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 17:31:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-27 17:34:00]

Description was changed from

==========
Remove |certificate_error_code| and SpdySession::TryAccessStream().

SpdySessionPool::CreateAvailableSessionFromSocket() is always called with a
hardcoded OK value for its |certificate_error_code| argument, so this can be
removed.  SpdySession::InitializeWithSocket() is only called from
SpdySessionPool::CreateAvailableSessionFromSocket() with |certificate_error_code
== OK|, so that argument can be removed as well.  Then
SpdySession::certificate_error_code_ member is always OK, so that can be removed
as well.  This makes SpdySession::TryAccessStream() always return OK, so that
can also be removed.

Metrics show that
SpdyProtocolErrorDetails::PROTOCOL_ERROR_REQUEST_FOR_SECURE_CONTENT_OVER_INSECURE_SESSION
is almost never (1e-11 of all counts) logged in Net.SpdySessionErrorDetails2.

BUG=624073
==========

to

==========
Remove |certificate_error_code| and SpdySession::TryAccessStream().

SpdySessionPool::CreateAvailableSessionFromSocket() is always called with a
hardcoded OK value for its |certificate_error_code| argument, so this can be
removed.  SpdySession::InitializeWithSocket() is only called from
SpdySessionPool::CreateAvailableSessionFromSocket() with |certificate_error_code
== OK|, so that argument can be removed as well.  Then
SpdySession::certificate_error_code_ member is always OK, so that can be removed
as well.  This makes SpdySession::TryAccessStream() always return OK, so that
can also be removed.

Metrics show that
SpdyProtocolErrorDetails::PROTOCOL_ERROR_REQUEST_FOR_SECURE_CONTENT_OVER_INSECURE_SESSION
is almost never (1e-11 of all counts) logged in Net.SpdySessionErrorDetails2.

BUG=624073

Committed: https://crrev.com/2c06a30cf92373b0cb4b721a4a8dac6d72635b93
Cr-Commit-Position: refs/heads/master@{#421250}
==========

[commit-bot: I haz the power, 2016-09-27 17:34:01]

Patchset 1 (id:??) landed as
https://crrev.com/2c06a30cf92373b0cb4b721a4a8dac6d72635b93
Cr-Commit-Position: refs/heads/master@{#421250}