Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: net/spdy/spdy_session.h

Issue 2371943003: Remove |certificate_error_code| and SpdySession::TryAccessStream(). (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl_job.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.h
diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h
index 30750e2309424101a3eddf87446d7f999f3b47ba..903c42b3a28021d71895e9a5acbc3467e246299c 100644
--- a/net/spdy/spdy_session.h
+++ b/net/spdy/spdy_session.h
@@ -333,16 +333,12 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
// |pool| is the SpdySessionPool that owns us. Its lifetime must
// strictly be greater than |this|.
//
- // |certificate_error_code| must either be OK or less than
- // ERR_IO_PENDING.
Ryan Hamilton 2016/09/27 17:17:50 OH! I'll bet this is a hold-over from the days whe
- //
// The session begins reading from |connection| on a subsequent event loop
// iteration, so the SpdySession may close immediately afterwards if the first
// read of |connection| fails.
void InitializeWithSocket(std::unique_ptr<ClientSocketHandle> connection,
SpdySessionPool* pool,
- bool is_secure,
- int certificate_error_code);
+ bool is_secure);
// Check to see if this SPDY session can support an additional domain.
// If the session is un-authenticated, then this call always returns true.
@@ -645,12 +641,6 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
WRITE_STATE_DO_WRITE_COMPLETE,
};
- // Checks whether a stream for the given |url| can be created or
- // retrieved from the set of unclaimed push streams. Returns OK if
- // so. Otherwise, the session is closed and an error <
- // ERR_IO_PENDING is returned.
- Error TryAccessStream(const GURL& url);
-
// Called by SpdyStreamRequest to start a request to create a
// stream. If OK is returned, then |stream| will be filled in with a
// valid stream. If ERR_IO_PENDING is returned, then
@@ -1078,9 +1068,6 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
// Flag if we're using an SSL connection for this SpdySession.
bool is_secure_;
- // Certificate error code when using a secure connection.
- int certificate_error_code_;
-
// Spdy Frame state.
std::unique_ptr<BufferedSpdyFramer> buffered_spdy_framer_;
« no previous file with comments | « net/http/http_stream_factory_impl_job.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698