Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2371803002: Updating the method called when System UI visibility/size changes (Closed)

Created:
4 years, 2 months ago by joedow
Modified:
4 years, 2 months ago
Reviewers:
Lambros
CC:
chromium-reviews, agrieve+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating the method called when System UI visibility/size changes This change updates the method used by the TouchInputHandler to inform the DesktopCanvas class of System UI state and size changes. BUG=621633 Committed: https://crrev.com/a4cb46ccf3108d8a2629df84bc081001fbd7d629 Cr-Commit-Position: refs/heads/master@{#420952}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java View 2 chunks +11 lines, -6 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
joedow
PTAL! CL 2 of ~4 for the System UI scrolling changes. Thanks, Joe
4 years, 2 months ago (2016-09-26 18:41:45 UTC) #6
Lambros
lgtm
4 years, 2 months ago (2016-09-26 18:44:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371803002/1
4 years, 2 months ago (2016-09-26 18:49:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 18:56:49 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 18:58:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4cb46ccf3108d8a2629df84bc081001fbd7d629
Cr-Commit-Position: refs/heads/master@{#420952}

Powered by Google App Engine
This is Rietveld 408576698