Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2367423002: Change Viewport calculations to use screen size without System UI (Closed)

Created:
4 years, 2 months ago by joedow
Modified:
4 years, 2 months ago
Reviewers:
Lambros
CC:
chromium-reviews, agrieve+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change Viewport calculations to use screen size without System UI This change updates code used to calculate the size of the viewport. In the past we would subtract the System UI edges from the viewport size which could cause odd problems when allowing the canvas to be moved out from under the System UI. BUG=621633 Committed: https://crrev.com/6f267f635b978d7f4fe4899c302c2126978dc102 Cr-Commit-Position: refs/heads/master@{#420949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -22 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java View 5 chunks +8 lines, -22 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
joedow
This is the first of ~4 CLs to allow users to pan the desktop canvas ...
4 years, 2 months ago (2016-09-26 17:17:54 UTC) #6
Lambros
lgtm
4 years, 2 months ago (2016-09-26 18:36:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367423002/1
4 years, 2 months ago (2016-09-26 18:41:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 18:47:54 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 18:49:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f267f635b978d7f4fe4899c302c2126978dc102
Cr-Commit-Position: refs/heads/master@{#420949}

Powered by Google App Engine
This is Rietveld 408576698