Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 23717036: mac&ios: Do not disable CLANG_WARN_CXX0X_EXTENSIONS. (Closed)

Created:
7 years, 3 months ago by Nico
Modified:
7 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

mac&ios: Do not disable CLANG_WARN_CXX0X_EXTENSIONS. Both Mac and iOS build in C++11 mode by now, and clang won't warn about C++11 extensions when building in C++11 mode. BUG=none R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222042

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M build/common.gypi View 1 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
7 years, 3 months ago (2013-09-09 00:23:19 UTC) #1
Mark Mentovai
LGTM
7 years, 3 months ago (2013-09-09 15:55:42 UTC) #2
Nico
7 years, 3 months ago (2013-09-09 16:00:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r222042 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698