Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: build/common.gypi

Issue 23717036: mac&ios: Do not disable CLANG_WARN_CXX0X_EXTENSIONS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index e1845fce70f1e87d72245536f86adad7b2cdc655..08b56cdeac8072cbe0e58a1fc012b0f2d57e45a5 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3880,11 +3880,6 @@
# gnu++11 (once typeof can be removed, which is blocked on c++11
# being available everywhere).
'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++11', # -std=gnu++11
- # Don't use -Wc++0x-extensions, which Xcode 4 enables by default
- # when building with clang. This warning is triggered when the
- # override keyword is used via the OVERRIDE macro from
- # base/compiler_specific.h.
- 'CLANG_WARN_CXX0X_EXTENSIONS': 'NO',
# Warn if automatic synthesis is triggered with
# the -Wobjc-missing-property-synthesis flag.
'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'YES',
@@ -4175,16 +4170,11 @@
# This next block is mostly common with the 'mac' section above,
# but keying off (or setting) 'clang' isn't valid for iOS as it
- # also seems to mean using the custom build of clang.
+ # also means using Chromium's build of clang.
# TODO(stuartmorgan): switch to c++0x (see TODOs in the clang
# section above).
'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++0x',
- # Don't use -Wc++0x-extensions, which Xcode 4 enables by default
- # when building with clang. This warning is triggered when the
- # override keyword is used via the OVERRIDE macro from
- # base/compiler_specific.h.
- 'CLANG_WARN_CXX0X_EXTENSIONS': 'NO',
# Warn if automatic synthesis is triggered with
# the -Wobjc-missing-property-synthesis flag.
'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'YES',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698