Disable submit button briefly when launching rAc dialog

chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

Index: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
index 1f88e9f20abf6aeab3e7a734214334bb107e6026..3186e0652ea9530a43dd3edd6446f09b47139599 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
@@ -288,6 +288,19 @@ class TestAutofillDialogController
 #endif
   }
 
+  void SimulateSubmitButtonDelayBegin() {
+    // 10 second delay to avoid test flakiness. The test would be flaky if this
+    // delay expired before the test finishes. This delay does not affect
+    // execution time of the test.
+    static const int kSimulatedSubmitButtonDelayMs = 10000;
+    AutofillDialogControllerImpl::SubmitButtonDelayBegin(
+        kSimulatedSubmitButtonDelayMs);
+  }
+
+  void SimulateSubmitButtonDelayEnd() {
+    AutofillDialogControllerImpl::OnSubmitButtonDelayEnd();
+  }
+
   MOCK_METHOD0(LoadRiskFingerprintData, void());
   using AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData;
   using AutofillDialogControllerImpl::IsEditingExistingData;
@@ -318,6 +331,14 @@ class TestAutofillDialogController
                                            billing_profile.Pass());
   }
 
+  virtual void SubmitButtonDelayBegin(int delay_ms) OVERRIDE {

[Evan Stade, 2013/09/04 21:42:52]

You don't verify that production code ever calls this function. I think you
should have a way to make this pass through to the super's impl (just in the
case of the new test), then can you verify that the submit button is disabled
when the view gets Show().

[please use gerrit instead, 2013/09/05 02:30:58]

I've overridden SubmitButtonDelayBegin() to increment a counter in testing and
added a test that verifies that this counter is equal to 1 after the dialog has
been shown.

+    // Ignore in testing.
+  }
+
+  virtual void OnSubmitButtonDelayEnd() OVERRIDE {
+    // Ignore in testing.
+  }
+
  private:
   // To specify our own metric logger.
   virtual const AutofillMetrics& GetMetricLogger() const OVERRIDE {
@@ -2391,4 +2412,12 @@ TEST_F(AutofillDialogControllerTest,
   EXPECT_FALSE(controller()->ShouldSaveInChrome());
 }
 
+TEST_F(AutofillDialogControllerTest, SubmitButtonDelayedOnStart) {
+  controller()->SimulateSubmitButtonDelayBegin();
+  SwitchToAutofill();

[Evan Stade, 2013/09/04 21:42:52]

do you need this?

[please use gerrit instead, 2013/09/05 02:30:58]

SwitchToAutofill() was to get rid of the wallet's loading spinner, which also
blocks the submit button. I've split this test case into three test cases for
clarity and increased coverage:

1) Wallet loading finishes before the delay timer.
2) Wallet loading finishes after the delay timer.
3) Wallet loading is ignored in autofill mode.

+  EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+  controller()->SimulateSubmitButtonDelayEnd();
+  EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+}
+
 }  // namespace autofill