Disable submit button briefly when launching rAc dialog

chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/guid.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 270 matching lines @@
     OnWalletSigninError();
   }
 
   // Skips past the 2 second wait between FinishSubmit and DoFinishSubmit.
   void ForceFinishSubmit() {
 #if defined(TOOLKIT_VIEWS)
     DoFinishSubmit();
 #endif
   }
 
+  void SimulateSubmitButtonDelayBegin() {
+    // 10 second delay to avoid test flakiness. The test would be flaky if this
+    // delay expired before the test finishes. This delay does not affect
+    // execution time of the test.
+    static const int kSimulatedSubmitButtonDelayMs = 10000;
+    AutofillDialogControllerImpl::SubmitButtonDelayBegin(
+        kSimulatedSubmitButtonDelayMs);
+  }
+
+  void SimulateSubmitButtonDelayEnd() {
+    AutofillDialogControllerImpl::OnSubmitButtonDelayEnd();
+  }
+
   MOCK_METHOD0(LoadRiskFingerprintData, void());
   using AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData;
   using AutofillDialogControllerImpl::IsEditingExistingData;
 
  protected:
   virtual PersonalDataManager* GetManager() OVERRIDE {
     return &test_manager_;
   }
 
   virtual wallet::WalletClient* GetWalletClient() OVERRIDE {
@@ skipping 10 matching lines @@
     return true;
   }
 
   virtual void ShowNewCreditCardBubble(
       scoped_ptr<CreditCard> new_card,
       scoped_ptr<AutofillProfile> billing_profile) OVERRIDE {
     mock_new_card_bubble_controller_->Show(new_card.Pass(),
                                            billing_profile.Pass());
   }
 
+  virtual void SubmitButtonDelayBegin(int delay_ms) OVERRIDE {

[Evan Stade, 2013/09/04 21:42:52]

You don't verify that production code ever calls this function. I think you
should have a way to make this pass through to the super's impl (just in the
case of the new test), then can you verify that the submit button is disabled
when the view gets Show().

[please use gerrit instead, 2013/09/05 02:30:58]

I've overridden SubmitButtonDelayBegin() to increment a counter in testing and
added a test that verifies that this counter is equal to 1 after the dialog has
been shown.

+    // Ignore in testing.
+  }
+
+  virtual void OnSubmitButtonDelayEnd() OVERRIDE {
+    // Ignore in testing.
+  }
+
  private:
   // To specify our own metric logger.
   virtual const AutofillMetrics& GetMetricLogger() const OVERRIDE {
     return metric_logger_;
   }
 
   const AutofillMetrics& metric_logger_;
   TestPersonalDataManager test_manager_;
   testing::NiceMock<wallet::MockWalletClient> mock_wallet_client_;
   GURL open_tab_url_;
@@ skipping 2053 matching lines @@
 TEST_F(AutofillDialogControllerTest,
        SaveInChromePreferenceRememberedOnSuccess) {
   EXPECT_TRUE(controller()->ShouldSaveInChrome());
   SwitchToAutofill();
   FillCreditCardInputs();
   controller()->GetView()->CheckSaveDetailsLocallyCheckbox(false);
   controller()->OnAccept();
   EXPECT_FALSE(controller()->ShouldSaveInChrome());
 }
 
+TEST_F(AutofillDialogControllerTest, SubmitButtonDelayedOnStart) {
+  controller()->SimulateSubmitButtonDelayBegin();
+  SwitchToAutofill();

[Evan Stade, 2013/09/04 21:42:52]

do you need this?

[please use gerrit instead, 2013/09/05 02:30:58]

SwitchToAutofill() was to get rid of the wallet's loading spinner, which also
blocks the submit button. I've split this test case into three test cases for
clarity and increased coverage:

1) Wallet loading finishes before the delay timer.
2) Wallet loading finishes after the delay timer.
3) Wallet loading is ignored in autofill mode.

+  EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+  controller()->SimulateSubmitButtonDelayEnd();
+  EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+}
+
 }  // namespace autofill