Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 23717007: [Files.app] Refinement events of suggest app dialog (Closed)

Created:
7 years, 3 months ago by yoshiki
Modified:
7 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

[Files.app] Refinement events of suggest app dialog Major changes. - Add animation on laading - Add a spinner on loading - Handle failure of widget loading - Refine the internal states of SuggestAppDialog BUG=240152 TEST=manual R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220553

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -54 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/cws_container_client.js View 1 2 5 chunks +38 lines, -6 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 2 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/resources/file_manager/js/suggest_apps_dialog.js View 1 2 10 chunks +162 lines, -41 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yoshiki
@hirono, could you take a look? Thanks.
7 years, 3 months ago (2013-08-30 08:44:37 UTC) #1
hirono
Thanks! https://codereview.chromium.org/23717007/diff/9001/chrome/browser/resources/file_manager/js/cws_container_client.js File chrome/browser/resources/file_manager/js/cws_container_client.js (right): https://codereview.chromium.org/23717007/diff/9001/chrome/browser/resources/file_manager/js/cws_container_client.js#newcode80 chrome/browser/resources/file_manager/js/cws_container_client.js:80: this.dispatchEvent(new cr.Event('loaded')); Can we make the event names ...
7 years, 3 months ago (2013-08-30 09:06:18 UTC) #2
yoshiki
@hirono, PTAL https://codereview.chromium.org/23717007/diff/9001/chrome/browser/resources/file_manager/js/cws_container_client.js File chrome/browser/resources/file_manager/js/cws_container_client.js (right): https://codereview.chromium.org/23717007/diff/9001/chrome/browser/resources/file_manager/js/cws_container_client.js#newcode80 chrome/browser/resources/file_manager/js/cws_container_client.js:80: this.dispatchEvent(new cr.Event('loaded')); On 2013/08/30 09:06:19, hirono wrote: ...
7 years, 3 months ago (2013-08-30 09:16:02 UTC) #3
hirono
lgtm! Thanks.
7 years, 3 months ago (2013-08-30 09:20:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/23717007/14001
7 years, 3 months ago (2013-08-30 09:21:50 UTC) #5
yoshiki
7 years, 3 months ago (2013-08-30 11:35:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r220553 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698