Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 23717007: [Files.app] Refinement events of suggest app dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comment Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/js/file_manager.js
diff --git a/chrome/browser/resources/file_manager/js/file_manager.js b/chrome/browser/resources/file_manager/js/file_manager.js
index bab9f52f63461b1926f4842ff5da24d03234bd5a..da60aa3aa62bf9f74c0da1c29a462f23f84fe187 100644
--- a/chrome/browser/resources/file_manager/js/file_manager.js
+++ b/chrome/browser/resources/file_manager/js/file_manager.js
@@ -2355,9 +2355,9 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
tasks.init(urls, mimeTypes);
tasks.executeDefault();
}.bind(this),
- // Failure callback.
- function() {},
// Cancelled callback.
+ function() {},
+ // Failure callback.
showAlert);
}.bind(this));
}
@@ -2397,11 +2397,17 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
var mime = props[0].contentMimeType;
this.suggestAppsDialog.show(
extension, mime,
- function(installed) {
- if (installed)
- onSuccess();
- else
- onCancelled();
+ function(result) {
+ switch (result) {
+ case SuggestAppsDialog.Result.INSTALL_SUCCESSFUL:
+ onSuccess();
+ break;
+ case SuggestAppsDialog.Result.FAILED:
+ onFailure();
+ break;
+ default:
+ onCancelled();
+ }
});
}.bind(this));
};

Powered by Google App Engine
This is Rietveld 408576698