Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2371593002: Make SVGAnimatedBoolean.h less popular (Closed)

Created:
4 years, 2 months ago by fs
Modified:
4 years, 2 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SVGAnimatedBoolean.h less popular SVGAnimatedBoolean is only used by/for SVGFEConvolveMatrix, but was being included in a lot of places. Remove the unnecessary includes of SVGAnimatedBoolean.h, and also remove some other obvious unnecessary includes in the vicinity. Committed: https://crrev.com/fcb0a568027331eec85b3d7ee1e28e5d7aa01a11 Cr-Commit-Position: refs/heads/master@{#420993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGCircleElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGClipPathElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGDefsElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGEllipseElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterElement.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGForeignObjectElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLineElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMPathElement.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMarkerElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMaskElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPolyElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRectElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGScriptElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSwitchElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSymbolElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextContentElement.h View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
fs
4 years, 2 months ago (2016-09-26 10:42:42 UTC) #6
Stephen Chennney
lgtm
4 years, 2 months ago (2016-09-26 15:00:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371593002/1
4 years, 2 months ago (2016-09-26 17:58:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 21:14:16 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 21:17:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcb0a568027331eec85b3d7ee1e28e5d7aa01a11
Cr-Commit-Position: refs/heads/master@{#420993}

Powered by Google App Engine
This is Rietveld 408576698