Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2361973003: Reduce includes of some SVG*TearOff types (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 2 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce includes of some SVG*TearOff types SVG*TearOff types are only of real interest to the bindings, so don't need to be included in something that isn't direclty interacting with bindings. Shuffle declarations and definitions to reduce the impact of SVGPointTearOff and SVGRectTearOff. Committed: https://crrev.com/dfbc0aacf84a5a625f2ba265bbae52aeaa3e30f9 Cr-Commit-Position: refs/heads/master@{#420920}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.h View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextContentElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (13 generated)
fs
4 years, 2 months ago (2016-09-25 21:53:43 UTC) #10
Stephen Chennney
LGTM.
4 years, 2 months ago (2016-09-26 14:58:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361973003/20001
4 years, 2 months ago (2016-09-26 16:02:27 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286182)
4 years, 2 months ago (2016-09-26 16:45:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361973003/20001
4 years, 2 months ago (2016-09-26 16:47:43 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-26 17:28:27 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 17:31:56 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfbc0aacf84a5a625f2ba265bbae52aeaa3e30f9
Cr-Commit-Position: refs/heads/master@{#420920}

Powered by Google App Engine
This is Rietveld 408576698