Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2371533002: [MD settings] I-beam cursor on settings input (Closed)

Created:
4 years, 3 months ago by dschuyler
Modified:
4 years, 2 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] I-beam cursor on settings input This CL restores the I-beam cursor to the settings-input edit field. It also has some cleanup: removing old .css imports and old css entries. (I can remove the cleanup from the CL if desired). BUG=645086 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f3c980356a027a87a77f70cd83d20c0437313256 Cr-Commit-Position: refs/heads/master@{#421416}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M chrome/browser/resources/settings/controls/settings_checkbox.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_input.html View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/resources/settings/downloads_page/downloads_page.html View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
dschuyler
https://codereview.chromium.org/2371533002/diff/1/chrome/browser/resources/settings/controls/settings_input.html File chrome/browser/resources/settings/controls/settings_input.html (right): https://codereview.chromium.org/2371533002/diff/1/chrome/browser/resources/settings/controls/settings_input.html#newcode11 chrome/browser/resources/settings/controls/settings_input.html:11: cursor: auto; This is the primary change.
4 years, 3 months ago (2016-09-24 01:03:39 UTC) #5
michaelpg
lgtm
4 years, 2 months ago (2016-09-25 18:21:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371533002/1
4 years, 2 months ago (2016-09-26 18:19:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286427)
4 years, 2 months ago (2016-09-26 19:56:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371533002/1
4 years, 2 months ago (2016-09-28 00:25:53 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 01:25:09 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 01:28:36 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3c980356a027a87a77f70cd83d20c0437313256
Cr-Commit-Position: refs/heads/master@{#421416}

Powered by Google App Engine
This is Rietveld 408576698