Apply SVG root viewport clips in PaintLayerClipper.

Apply SVG root viewport clips in PaintLayerClipper.

This will not only improve the accuracy of the clip rects generated, but more
importantly, make clipping behavior in this class consistent with the clips
generated by SPv2 paint property trees.

BUG=593596
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/6e00ec86f8876f35268cae04aef4f59d66b2d289
Cr-Commit-Position: refs/heads/master@{#420971}

[chrishtr, 2016-09-23 23:55:24]

Description was changed from

==========
none


none


none

BUG=
==========

to

==========
none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-09-23 23:57:34]

Description was changed from

==========
none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Apply SVG root viewport clips in PaintLayerClipper.

BUG=593596
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-09-23 23:57:37]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 23:58:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 00:30:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 00:30:13]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-09-24 21:27:22]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-24 21:27:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 21:41:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 21:41:26]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-09-24 22:07:58]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-24 22:08:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 22:32:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 22:32:49]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-09-26 16:42:42]

Description was changed from

==========
Apply SVG root viewport clips in PaintLayerClipper.

BUG=593596
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Apply SVG root viewport clips in PaintLayerClipper.

This will not only improve the accuracy of the clip rects generated, but more
importantly, make clipping behavior in this class consistent with the clips
generated by SPv2 paint property trees.

BUG=593596
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-09-26 16:43:57]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[chrishtr, 2016-09-26 16:43:58]

This is patch 1 of 2 to unblock GeometryMapper in PaintLayerClipper. The other
is
https://codereview.chromium.org/2368043002.

[chrishtr, 2016-09-26 16:44:02]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 16:44:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 17:03:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 17:03:35]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[pdr., 2016-09-26 17:04:52]

LGTM

https://codereview.chromium.org/2371523002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp (right):

https://codereview.chromium.org/2371523002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp:1: // Copyright
2014 The Chromium Authors. All rights reserved.
Nit: 2016

https://codereview.chromium.org/2371523002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp:24:
setBodyInnerHTML("<!DOCTYPE html>"
Nit: I recently learned setBodyInnerHTML literally sets the body html, so this
doctype will get ignored. I'd recommend just removing this.

[chrishtr, 2016-09-26 17:37:54]

https://codereview.chromium.org/2371523002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp (right):

https://codereview.chromium.org/2371523002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp:1: // Copyright
2014 The Chromium Authors. All rights reserved.
On 2016/09/26 at 17:04:52, pdr. wrote:
> Nit: 2016

Done.

https://codereview.chromium.org/2371523002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp:24:
setBodyInnerHTML("<!DOCTYPE html>"
On 2016/09/26 at 17:04:52, pdr. wrote:
> Nit: I recently learned setBodyInnerHTML literally sets the body html, so this
doctype will get ignored. I'd recommend just removing this.

Done.

[chrishtr, 2016-09-26 17:37:59]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-26 17:37:59]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2371523002/#ps180001
(title: "none")

[commit-bot: I haz the power, 2016-09-26 17:38:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 17:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 17:51:10]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[chrishtr, 2016-09-26 17:53:34]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-26 17:53:35]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2371523002/#ps200001
(title: "none")

[commit-bot: I haz the power, 2016-09-26 17:54:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 20:13:09]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-09-26 20:15:39]

Description was changed from

==========
Apply SVG root viewport clips in PaintLayerClipper.

This will not only improve the accuracy of the clip rects generated, but more
importantly, make clipping behavior in this class consistent with the clips
generated by SPv2 paint property trees.

BUG=593596
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Apply SVG root viewport clips in PaintLayerClipper.

This will not only improve the accuracy of the clip rects generated, but more
importantly, make clipping behavior in this class consistent with the clips
generated by SPv2 paint property trees.

BUG=593596
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/6e00ec86f8876f35268cae04aef4f59d66b2d289
Cr-Commit-Position: refs/heads/master@{#420971}
==========

[commit-bot: I haz the power, 2016-09-26 20:15:41]

Patchset 11 (id:??) landed as
https://crrev.com/6e00ec86f8876f35268cae04aef4f59d66b2d289
Cr-Commit-Position: refs/heads/master@{#420971}