Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2368043002: [SPv2] Separate SVG root viewport clip from overflow clip. (Closed)

Created:
4 years, 2 months ago by chrishtr
Modified:
4 years, 2 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPv2] Separate SVG root viewport clip from overflow clip. This will allow us to apply different clipping behavior in PaintLayerClipper for those two types of clips, which is necessary because PaintLayerPainter should apply overflow clip for a fragment's foregroundRect, but not the SVG root viewport clip (the latter does not include box decoration bounds of the fragment, for example, so applying it will cut off box decorations such as border). BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Patch Set 4 : none #

Patch Set 5 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M third_party/WebKit/Source/core/paint/ObjectPaintProperties.h View 1 4 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 3 chunks +21 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (13 generated)
chrishtr
4 years, 2 months ago (2016-09-26 17:48:45 UTC) #10

          

Powered by Google App Engine
This is Rietveld 408576698