[MD History] Fix item selection when deleting via menu item.

[MD History] Fix item selection when deleting via menu item.

This CL fixes an issue where an item in the history list would stay
selected when deleting via the menu item with multiple items selected.
This was happening because the unselect call would trigger against
outdated selection paths.

BUG=642665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f5da8e21e5b0a869e701797c6d854519ed5416a8
Cr-Commit-Position: refs/heads/master@{#421773}

[calamity, 2016-09-28 02:41:01]

Description was changed from

==========
[MD History] Fix item selection when deleting via menu item.

This CL fixes an issue where an item in the history list would stay
selected when deleting via the menu item with multiple items selected.
This was happening because the unselect call would trigger against
outdated selection paths.

BUG=642665
==========

to

==========
[MD History] Fix item selection when deleting via menu item.

This CL fixes an issue where an item in the history list would stay
selected when deleting via the menu item with multiple items selected.
This was happening because the unselect call would trigger against
outdated selection paths.

BUG=642665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-09-28 02:41:11]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 02:41:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 03:44:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 03:44:24]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-09-29 00:53:08]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-09-29 01:45:01]

You'll need to rebase for crisper.js, since it is ugly now.

https://codereview.chromium.org/2371363002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/list_container.js (right):

https://codereview.chromium.org/2371363002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/list_container.js:241: // This unselect-all
is to reset the toolbar when deleting a selected
While you're here, can you please update this comment? Clearing the selection is
now needed because selection state becomes invalid when items move around.

[calamity, 2016-09-29 03:06:16]

Patchset #2 (id:20001) has been deleted

[calamity, 2016-09-29 03:06:23]

https://codereview.chromium.org/2371363002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/list_container.js (right):

https://codereview.chromium.org/2371363002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/list_container.js:241: // This unselect-all
is to reset the toolbar when deleting a selected
On 2016/09/29 01:45:01, tsergeant wrote:
> While you're here, can you please update this comment? Clearing the selection
is
> now needed because selection state becomes invalid when items move around.

Done.

[tsergeant, 2016-09-29 03:18:03]

lgtm

[calamity, 2016-09-29 05:51:53]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-09-29 05:52:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 07:48:54]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-29 07:52:34]

Description was changed from

==========
[MD History] Fix item selection when deleting via menu item.

This CL fixes an issue where an item in the history list would stay
selected when deleting via the menu item with multiple items selected.
This was happening because the unselect call would trigger against
outdated selection paths.

BUG=642665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Fix item selection when deleting via menu item.

This CL fixes an issue where an item in the history list would stay
selected when deleting via the menu item with multiple items selected.
This was happening because the unselect call would trigger against
outdated selection paths.

BUG=642665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f5da8e21e5b0a869e701797c6d854519ed5416a8
Cr-Commit-Position: refs/heads/master@{#421773}
==========

[commit-bot: I haz the power, 2016-09-29 07:52:35]

Patchset 2 (id:??) landed as
https://crrev.com/f5da8e21e5b0a869e701797c6d854519ed5416a8
Cr-Commit-Position: refs/heads/master@{#421773}