Modify depot_tools instructions regarding %PATH%

Modify depot_tools instructions regarding %PATH%

The old depot_tools instructions insisted that depot_tools be the last
entry in the PATH environment variable, for reasons that are unclear and
may only have applied to Linux. Meanwhile, there is a gn issue that can
cause unnecessary building if depot_tools is not near the front of the
path - ahead of other Python installs. This change alters the
instructions for Windows.

This also removes some obsolete instructions regarding building Chrome
on Windows XP - Chrome doesn't even *run* on Windows XP anymore.

BUG=611087
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/dd55dc6d1c7de110bca46d939f56d2f519d54612

[brucedawson, 2016-09-28 00:59:51]

brucedawson@chromium.org changed reviewers:
+ agable@chromium.org

[agable, 2016-09-28 16:10:04]

Please don't directly edit the HTML files -- your change will be clobbered the
next time someone regenerates them. You need to edit the source file in
depot_tools/man/src, and then run depot_tools/man/make_docs.sh, which will
automatically regenerate both the html and man pages.

https://codereview.chromium.org/2371333002/diff/1/man/html/depot_tools_tutori...
File man/html/depot_tools_tutorial.html (right):

https://codereview.chromium.org/2371333002/diff/1/man/html/depot_tools_tutori...
man/html/depot_tools_tutorial.html:949: After running gclient open a command
prompt and type where python and confirm that
...and type `where python` to confirm...

[brucedawson, 2016-09-28 20:32:34]

Okay, redone.

Running that script updates dozens of files, due to changed dates, changed
hashes, and a change in the script that means that .git is appended to many
URLs.

There is also at least one /html change that looks like it resulted from a
previous source change that didn't get copied over because the shell script was
never run.

Should I revert all of the files that are not related to my change (leaving just
two) or land everything?

https://codereview.chromium.org/2371333002/diff/1/man/html/depot_tools_tutori...
File man/html/depot_tools_tutorial.html (right):

https://codereview.chromium.org/2371333002/diff/1/man/html/depot_tools_tutori...
man/html/depot_tools_tutorial.html:949: After running gclient open a command
prompt and type where python and confirm that
On 2016/09/28 16:10:04, agable wrote:
> ...and type `where python` to confirm...

Done.

[agable, 2016-09-28 20:37:17]

Sweet. Yeah, feel free to 'git checkout origin/master -- <files that only have
hash/date changes>' and not include them in the CL.

I'm working on figuring out why the auto-svn lines came back; they definitely
shouldn't have been regenerated... Is your CL based on top of the most recent
depot_tools master commit?

[agable, 2016-09-28 20:45:14]

On 2016/09/28 at 20:37:17, agable wrote:
> Sweet. Yeah, feel free to 'git checkout origin/master -- <files that only have
hash/date changes>' and not include them in the CL.
> 
> I'm working on figuring out why the auto-svn lines came back; they definitely
shouldn't have been regenerated... Is your CL based on top of the most recent
depot_tools master commit?

Yeah, I just patched in your patchset 2 (which contains only the diff to
src/depot_tools_tutorial.txt), and regenerated the docs, and it only resulted in
diffs to the two appropriate files. I'm not sure what's going on in your
checkout.

[agable, 2016-09-28 20:48:40]

On 2016/09/28 at 20:45:14, agable wrote:
> On 2016/09/28 at 20:37:17, agable wrote:
> > Sweet. Yeah, feel free to 'git checkout origin/master -- <files that only
have hash/date changes>' and not include them in the CL.
> > 
> > I'm working on figuring out why the auto-svn lines came back; they
definitely shouldn't have been regenerated... Is your CL based on top of the
most recent depot_tools master commit?
> 
> Yeah, I just patched in your patchset 2 (which contains only the diff to
src/depot_tools_tutorial.txt), and regenerated the docs, and it only resulted in
diffs to the two appropriate files. I'm not sure what's going on in your
checkout.

(Here's what my checkout produces: https://codereview.chromium.org/2375203002)

[brucedawson, 2016-09-28 22:44:50]

Okay, I got it working. It's a finicky process.

> > Yeah, I just patched in your patchset 2 (which contains only the diff to
> src/depot_tools_tutorial.txt), and regenerated the docs, and it only resulted
in
> diffs to the two appropriate files. I'm not sure what's going on in your
> checkout.
> 
> (Here's what my checkout produces: https://codereview.chromium.org/2375203002)

Unfortunately patchset 2 is not correct - its link to the bug was done using raw
html. I fixed that later.

I did a 'git pull' before starting so my depot_tools repo is entirely
up-to-date.

Frustratingly enough when I ran man/src/make_docs.sh in a fresh branch with just
the cherry-picked change to man/src/depot_tools_tutorial.txt, it did nothing -
no files altered at all.

Apparently there is some sort of caching of the results so that if you run
make_docs.sh twice - even if you are on a new branch that does not have the
altered .html files - it does nothing. It somehow detects that there is nothing
to do (incorrectly).

Therefore, the necessary/required process is to run make_docs.sh before your
changes, and then again after. Or something like that. I got it to work by
switching back to master, running it, then switching to the branch with my .txt
change and nothing else and running it again.

Looks good now. Minimal changes and no manual reverting required.

[agable, 2016-09-29 18:56:52]

The CQ bit was checked by agable@chromium.org

[agable, 2016-09-29 18:56:53]

lgtm

[commit-bot: I haz the power, 2016-09-29 18:57:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 19:02:53]

Description was changed from

==========
Modify depot_tools instructions regarding %PATH%

The old depot_tools instructions insisted that depot_tools be the last
entry in the PATH environment variable, for reasons that are unclear and
may only have applied to Linux. Meanwhile, there is a gn issue that can
cause unnecessary building if depot_tools is not near the front of the
path - ahead of other Python installs. This change alters the
instructions for Windows.

This also removes some obsolete instructions regarding building Chrome
on Windows XP - Chrome doesn't even *run* on Windows XP anymore.

BUG=611087
==========

to

==========
Modify depot_tools instructions regarding %PATH%

The old depot_tools instructions insisted that depot_tools be the last
entry in the PATH environment variable, for reasons that are unclear and
may only have applied to Linux. Meanwhile, there is a gn issue that can
cause unnecessary building if depot_tools is not near the front of the
path - ahead of other Python installs. This change alters the
instructions for Windows.

This also removes some obsolete instructions regarding building Chrome
on Windows XP - Chrome doesn't even *run* on Windows XP anymore.

BUG=611087

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/dd55dc6d1c7de1...
==========

[commit-bot: I haz the power, 2016-09-29 19:02:54]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/dd55dc6d1c7de1...