Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Issue 2375203002: Modify depot_tools instructions regarding %PATH% (Closed)

Created:
4 years, 2 months ago by agable
Modified:
4 years ago
Reviewers:
brucedawson
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Modify depot_tools instructions regarding %PATH% The old depot_tools instructions insisted that depot_tools be the last entry in the PATH environment variable, for reasons that are unclear and may only have applied to Linux. Meanwhile, there is a gn issue that can cause unnecessary building if depot_tools is not near the front of the path - ahead of other Python installs. This change alters the instructions for Windows. This also removes some obsolete instructions regarding building Chrome on Windows XP - Chrome doesn't even *run* on Windows XP anymore. R=brucedawson@chromium.org BUG=611087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M man/html/depot_tools_tutorial.html View 4 chunks +9 lines, -9 lines 0 comments Download
M man/man7/depot_tools_tutorial.7 View 2 chunks +4 lines, -4 lines 0 comments Download
M man/src/depot_tools_tutorial.txt View 3 chunks +7 lines, -7 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698