Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2371223002: Keep top controls visible if SHOW is called right after HIDE. (Closed)

Created:
4 years, 2 months ago by Ted C
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Keep top controls visible if SHOW is called right after HIDE. Currently, we early exit if the visibility amount matches our desired ending amount. But when you set HIDDEN as the current, it will start an animation, and a immediate call to SHOWN will see that the ending condition is met and return, but does not clear the animation. Now, clear the animation if the current value matches our desired ending value to ensure it doesn't move. BUG=639702 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2372713004 Cr-Commit-Position: refs/heads/master@{#421125} Committed: https://chromium.googlesource.com/chromium/src/+/0f76844ee3219d0e3990216b5dd657aac4d36f7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M cc/input/top_controls_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/input/top_controls_manager_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ted C
4 years, 2 months ago (2016-09-27 17:09:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0f76844ee3219d0e3990216b5dd657aac4d36f7b.

Powered by Google App Engine
This is Rietveld 408576698