Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2372713004: Keep top controls visible if SHOW is called right after HIDE. (Closed)

Created:
4 years, 2 months ago by Ted C
Modified:
4 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep top controls visible if SHOW is called right after HIDE. Currently, we early exit if the visibility amount matches our desired ending amount. But when you set HIDDEN as the current, it will start an animation, and a immediate call to SHOWN will see that the ending condition is met and return, but does not clear the animation. Now, clear the animation if the current value matches our desired ending value to ensure it doesn't move. BUG=639702 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/a55c2fdf48fb379f994e21768f517b53837ea663 Cr-Commit-Position: refs/heads/master@{#421125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M cc/input/top_controls_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/input/top_controls_manager_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Ted C
PTAL
4 years, 2 months ago (2016-09-27 00:08:08 UTC) #3
aelias_OOO_until_Jul13
lgtm
4 years, 2 months ago (2016-09-27 04:25:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372713004/1
4 years, 2 months ago (2016-09-27 04:30:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 06:11:28 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 06:14:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a55c2fdf48fb379f994e21768f517b53837ea663
Cr-Commit-Position: refs/heads/master@{#421125}

Powered by Google App Engine
This is Rietveld 408576698