Improve CloudPolicyClient doc.

Improve CloudPolicyClient doc.

BUG=none

Committed: https://crrev.com/f54c3f6dfd782cd770df0538363ad686a4cdd4ba
Cr-Commit-Position: refs/heads/master@{#421209}

[Thiemo Nagel, 2016-09-27 13:40:52]

tnagel@chromium.org changed reviewers:
+ mnissler@chromium.org

[Thiemo Nagel, 2016-09-27 13:40:52]

As discussed, could you please take a look?

[Mattias Nissler (ping if slow), 2016-09-27 13:48:45]

I ain't got no powers, but LGTM :)

https://codereview.chromium.org/2371163002/diff/1/components/policy/core/comm...
File components/policy/core/common/cloud/cloud_policy_client.h (right):

https://codereview.chromium.org/2371163002/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/cloud_policy_client.h:85: // details.)
|service| and |signing_service| are weak pointers and it's the
nit: This suggests that bad the code will not work if machine_id or
machine_model are passed for user policy, which is not true. Maybe soften to
something like this:

If non-empty, |machine_id| and |machine_model| are passed to the server
verbatimly. Note that these reveal machine identity to the server, so should
only be used where this is appropriate (i.e. device policy, but not user
policy).

[Thiemo Nagel, 2016-09-27 14:11:49]

On 2016/09/27 13:48:45, Mattias Nissler (ping if slow) wrote:
> I ain't got no powers, but LGTM :)

You need no powers.  Thanks!

[Thiemo Nagel, 2016-09-27 14:11:54]

The CQ bit was checked by tnagel@chromium.org

[Thiemo Nagel, 2016-09-27 14:11:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
mnissler@chromium.org
Link to the patchset: https://codereview.chromium.org/2371163002/#ps20001
(title: "Using Mattias' text with slight modifications.")

[commit-bot: I haz the power, 2016-09-27 14:12:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 15:05:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-27 15:07:49]

Description was changed from

==========
Improve CloudPolicyClient doc.

BUG=none
==========

to

==========
Improve CloudPolicyClient doc.

BUG=none

Committed: https://crrev.com/f54c3f6dfd782cd770df0538363ad686a4cdd4ba
Cr-Commit-Position: refs/heads/master@{#421209}
==========

[commit-bot: I haz the power, 2016-09-27 15:07:50]

Patchset 2 (id:??) landed as
https://crrev.com/f54c3f6dfd782cd770df0538363ad686a4cdd4ba
Cr-Commit-Position: refs/heads/master@{#421209}