Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: components/policy/core/common/cloud/cloud_policy_client.h

Issue 2371163002: Improve CloudPolicyClient doc. (Closed)
Patch Set: Using Mattias' text with slight modifications. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/policy/core/common/cloud/cloud_policy_client.h
diff --git a/components/policy/core/common/cloud/cloud_policy_client.h b/components/policy/core/common/cloud/cloud_policy_client.h
index d2e3f8775256a9297ce8dfa6522cd9f0c9c77bf0..88f11b6c04e60fbb6fd5dae69c440b37bf7edf02 100644
--- a/components/policy/core/common/cloud/cloud_policy_client.h
+++ b/components/policy/core/common/cloud/cloud_policy_client.h
@@ -80,7 +80,10 @@ class POLICY_EXPORT CloudPolicyClient {
virtual void OnClientError(CloudPolicyClient* client) = 0;
};
- // |service| and |signing_service| are weak pointers and it's the caller's
+ // If non-empty, |machine_id| and |machine_model| are passed to the server
+ // verbatim. As these reveal machine identity, they must only be used where
+ // this is appropriate (i.e. device policy, but not user policy). |service|
+ // and |signing_service| are weak pointers and it's the caller's
// responsibility to keep them valid for the lifetime of CloudPolicyClient.
// |verification_key_hash| contains an identifier telling the DMServer which
// verification key to use. The |signing_service| is used to sign sensitive
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698