Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: ui/views/widget/root_view_unittest.cc

Issue 2371113003: Do not give instant focus if a view's toplevelwidget is not active (Closed)
Patch Set: add ClearNativeFocus() Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/root_view_unittest.cc
diff --git a/ui/views/widget/root_view_unittest.cc b/ui/views/widget/root_view_unittest.cc
index 7c414a29223d4dc09eedc40c071a445ad25f68d8..a7cf407913a0b666300b758e773c708e935152b9 100644
--- a/ui/views/widget/root_view_unittest.cc
+++ b/ui/views/widget/root_view_unittest.cc
@@ -41,9 +41,10 @@ class DeleteOnKeyEventView : public View {
TEST_F(RootViewTest, DeleteViewDuringKeyEventDispatch) {
Widget widget;
Widget::InitParams init_params =
- CreateParams(Widget::InitParams::TYPE_POPUP);
+ CreateParams(Widget::InitParams::TYPE_WINDOW_FRAMELESS);
init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
widget.Init(init_params);
+ widget.Show();
bool got_key_event = false;
@@ -111,9 +112,10 @@ class TestContextMenuController : public ContextMenuController {
TEST_F(RootViewTest, ContextMenuFromKeyEvent) {
Widget widget;
Widget::InitParams init_params =
- CreateParams(Widget::InitParams::TYPE_POPUP);
+ CreateParams(Widget::InitParams::TYPE_WINDOW_FRAMELESS);
init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
widget.Init(init_params);
+ widget.Show();
internal::RootView* root_view =
static_cast<internal::RootView*>(widget.GetRootView());

Powered by Google App Engine
This is Rietveld 408576698