ui/views/widget/widget_interactive_uitest.cc - Issue 2371113003: Do not give instant focus if a view's toplevelwidget is not active

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/widget_interactive_uitest.cc

Issue 2371113003: Do not give instant focus if a view's toplevelwidget is not active (Closed)

Patch Set: add ClearNativeFocus() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/widget/widget_interactive_uitest.cc

diff --git a/ui/views/widget/widget_interactive_uitest.cc b/ui/views/widget/widget_interactive_uitest.cc

index 141220c5fb59ca6d1b53a46dc32c4c8b24d056b1..f17d238057b8f7b6d29ef17626f218771a0c3b5f 100644

--- a/ui/views/widget/widget_interactive_uitest.cc

+++ b/ui/views/widget/widget_interactive_uitest.cc

@@ -1698,9 +1698,8 @@ TEST_F(WidgetInputMethodInteractiveTest, Activation) {

Widget* widget = CreateWidget();

Textfield* textfield = new Textfield;

widget->GetRootView()->AddChildView(textfield);

- textfield->RequestFocus();

ShowSync(widget);

+ textfield->RequestFocus();

EXPECT_EQ(ui::TEXT_INPUT_TYPE_TEXT,

widget->GetInputMethod()->GetTextInputType());