Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: net/url_request/url_request_job.cc

Issue 23710059: Release the cache entry on deferred redirect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable new tests on Chrome Frame Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_job.cc
diff --git a/net/url_request/url_request_job.cc b/net/url_request/url_request_job.cc
index 669c845de98ca142f111d00369c0d00075b0d65b..5ad78a23332735ae8622d8e59efe53144b2e591c 100644
--- a/net/url_request/url_request_job.cc
+++ b/net/url_request/url_request_job.cc
@@ -319,6 +319,11 @@ void URLRequestJob::NotifyHeadersComplete() {
new_location = new_location.ReplaceComponents(replacements);
}
+ // Tell lower-level layers to ignore the response body. This is
+ // both so the request is cached and to release the cache entry
rvargas (doing something else) 2013/09/17 19:53:25 nit: this comment ties this to the actual implemen
davidben 2013/09/17 22:16:04 Done.
+ // for future requests to access.
+ DoneReading();
+
bool defer_redirect = false;
request_->NotifyReceivedRedirect(new_location, &defer_redirect);

Powered by Google App Engine
This is Rietveld 408576698