Release the cache entry on deferred redirect.

net/url_request/url_request_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_job.h"
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/message_loop/message_loop.h"
 #include "base/power_monitor/power_monitor.h"
@@ skipping 301 matching lines @@
     // new one has none. This duplicates mozilla's behavior.
     if (url.is_valid() && url.has_ref() && !new_location.has_ref()) {
       GURL::Replacements replacements;
       // Reference the |ref| directly out of the original URL to avoid a
       // malloc.
       replacements.SetRef(url.spec().data(),
                           url.parsed_for_possibly_invalid_spec().ref);
       new_location = new_location.ReplaceComponents(replacements);
     }
 
+    // Tell lower-level layers to ignore the response body. This is
+    // both so the request is cached and to release the cache entry

[rvargas (doing something else), 2013/09/17 19:53:25]

nit: this comment ties this to the actual implementation details of the
HttpCache::Transaction so it is better if we don't do that. At a high level what
we are doing is stating that we are done with the transaction and there won't be
any subsequent call to it (as opposed to an abrupt termination caused by an
error).

[davidben, 2013/09/17 22:16:04]

Done.

+    // for future requests to access.
+    DoneReading();
+
     bool defer_redirect = false;
     request_->NotifyReceivedRedirect(new_location, &defer_redirect);
 
     // Ensure that the request wasn't detached or destroyed in
     // NotifyReceivedRedirect
     if (!request_ || !request_->has_delegate())
       return;
 
     // If we were not cancelled, then maybe follow the redirect.
     if (request_->status().is_success()) {
@@ skipping 395 matching lines @@
 }
 
 bool URLRequestJob::FilterHasData() {
     return filter_.get() && filter_->stream_data_len();
 }
 
 void URLRequestJob::UpdatePacketReadTimes() {
 }
 
 }  // namespace net