Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2805)

Unified Diff: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Issue 23710022: Convert NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED to CallbackList (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clean-up Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
index 9f39b0e20e701743e6be1448a399f816ec0bf3dc..3c925944adbcec01b19aa8d27da5fae9438f5894 100644
--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
@@ -263,11 +263,12 @@ class OmniboxViewTest : public InProcessBrowserTest,
ASSERT_TRUE(model);
if (!model->loaded()) {
- content::NotificationRegistrar registrar;
- registrar.Add(this, chrome::NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED,
- content::Source<TemplateURLService>(model));
+ base::RunLoop run_loop;
+ scoped_ptr<TemplateURLService::Subscription> sub =
+ model->RegisterOnLoadedCallback(
+ content::GetQuitTaskForRunLoop(&run_loop));
model->Load();
- content::RunMessageLoop();
+ content::RunThisRunLoop(&run_loop);
Avi (use Gerrit) 2013/10/02 22:27:52 Again, MessageLoopRunner?
Cait (Slow) 2013/10/03 15:36:45 Done.
}
ASSERT_TRUE(model->loaded());
@@ -364,7 +365,6 @@ class OmniboxViewTest : public InProcessBrowserTest,
case chrome::NOTIFICATION_AUTOCOMPLETE_CONTROLLER_RESULT_READY:
case chrome::NOTIFICATION_HISTORY_LOADED:
case chrome::NOTIFICATION_HISTORY_URLS_MODIFIED:
- case chrome::NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED:
break;
default:
FAIL() << "Unexpected notification type";

Powered by Google App Engine
This is Rietveld 408576698