Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2370913002: Removes AshTestBase::SupportsHostWindowResize (Closed)

Created:
4 years, 2 months ago by sky
Modified:
4 years, 2 months ago
Reviewers:
James Cook
CC:
chromium-reviews, alemate+watch_chromium.org, sadrul, achuith+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes AshTestBase::SupportsHostWindowResize It was only needed for metro, which isn't supported, so it can be removed. BUG=none TEST=none R=jamescook@chromium.org Committed: https://crrev.com/cc5431681d6cadaabfc8fa800e613eaebfa0e704 Cr-Commit-Position: refs/heads/master@{#420967}

Patch Set 1 #

Patch Set 2 : missed #

Total comments: 3

Patch Set 3 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -259 lines) Patch
M ash/app_list/app_list_presenter_delegate_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ash/mus/workspace/workspace_layout_manager_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/shell_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/toast/toast_manager_unittest.cc View 1 2 3 chunks +15 lines, -27 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/test/ash_test_base.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/test/ash_test_helper.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/test/ash_test_helper.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 1 18 chunks +3 lines, -47 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 28 chunks +2 lines, -77 lines 0 comments Download
M ash/wm/lock_layout_manager_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 4 chunks +0 lines, -20 lines 0 comments Download
M ash/wm/window_positioner_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/wm/window_state_unittest.cc View 6 chunks +0 lines, -17 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
sky
https://codereview.chromium.org/2370913002/diff/20001/ash/display/display_manager_unittest.cc File ash/display/display_manager_unittest.cc (right): https://codereview.chromium.org/2370913002/diff/20001/ash/display/display_manager_unittest.cc#newcode631 ash/display/display_manager_unittest.cc:631: // Disabled on windows because of http://crbug.com/650326. I had ...
4 years, 2 months ago (2016-09-26 19:07:47 UTC) #5
James Cook
Woo hoo! LGTM https://codereview.chromium.org/2370913002/diff/20001/ash/system/toast/toast_manager_unittest.cc File ash/system/toast/toast_manager_unittest.cc (right): https://codereview.chromium.org/2370913002/diff/20001/ash/system/toast/toast_manager_unittest.cc#newcode174 ash/system/toast/toast_manager_unittest.cc:174: // If host resize is not ...
4 years, 2 months ago (2016-09-26 19:21:11 UTC) #6
sky
https://codereview.chromium.org/2370913002/diff/20001/ash/system/toast/toast_manager_unittest.cc File ash/system/toast/toast_manager_unittest.cc (right): https://codereview.chromium.org/2370913002/diff/20001/ash/system/toast/toast_manager_unittest.cc#newcode174 ash/system/toast/toast_manager_unittest.cc:174: // If host resize is not supported, ShelfLayoutManager::GetIdealBounds() On ...
4 years, 2 months ago (2016-09-26 19:26:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370913002/40001
4 years, 2 months ago (2016-09-26 19:28:04 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-26 20:09:34 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 20:12:51 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/cc5431681d6cadaabfc8fa800e613eaebfa0e704
Cr-Commit-Position: refs/heads/master@{#420967}

Powered by Google App Engine
This is Rietveld 408576698