Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1435)

Unified Diff: ash/wm/panels/panel_window_resizer_unittest.cc

Issue 2370913002: Removes AshTestBase::SupportsHostWindowResize (Closed)
Patch Set: feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/overview/window_selector_unittest.cc ('k') | ash/wm/window_positioner_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/panels/panel_window_resizer_unittest.cc
diff --git a/ash/wm/panels/panel_window_resizer_unittest.cc b/ash/wm/panels/panel_window_resizer_unittest.cc
index 0e6cd43c9528ce4abee4d9a8309b099d4b304561..a3a96c6df908425660c500e828b6da28c3375ca5 100644
--- a/ash/wm/panels/panel_window_resizer_unittest.cc
+++ b/ash/wm/panels/panel_window_resizer_unittest.cc
@@ -228,26 +228,17 @@ class PanelWindowResizerTransientTest
// Verifies a window can be dragged from the panel and detached and then
// reattached.
TEST_F(PanelWindowResizerTest, PanelDetachReattachBottom) {
- if (!SupportsHostWindowResize())
- return;
-
std::unique_ptr<aura::Window> window(CreatePanelWindow(gfx::Point(0, 0)));
DetachReattachTest(window.get(), 0, -1);
}
TEST_F(PanelWindowResizerTest, PanelDetachReattachLeft) {
- if (!SupportsHostWindowResize())
- return;
-
GetPrimaryShelf()->SetAlignment(SHELF_ALIGNMENT_LEFT);
std::unique_ptr<aura::Window> window(CreatePanelWindow(gfx::Point(0, 0)));
DetachReattachTest(window.get(), 1, 0);
}
TEST_F(PanelWindowResizerTest, PanelDetachReattachRight) {
- if (!SupportsHostWindowResize())
- return;
-
GetPrimaryShelf()->SetAlignment(SHELF_ALIGNMENT_RIGHT);
std::unique_ptr<aura::Window> window(CreatePanelWindow(gfx::Point(0, 0)));
DetachReattachTest(window.get(), -1, 0);
@@ -256,8 +247,6 @@ TEST_F(PanelWindowResizerTest, PanelDetachReattachRight) {
// Tests that a drag continues when the shelf is hidden. This occurs as part of
// the animation when switching profiles. http://crbug.com/393047.
TEST_F(PanelWindowResizerTest, DetachThenHideShelf) {
- if (!SupportsHostWindowResize())
- return;
std::unique_ptr<aura::Window> window(CreatePanelWindow(gfx::Point(0, 0)));
wm::WindowState* state = wm::GetWindowState(window.get());
gfx::Rect expected_bounds = window->GetBoundsInScreen();
@@ -477,16 +466,10 @@ TEST_F(PanelWindowResizerTest, DragMovesToPanelLayer) {
}
TEST_P(PanelWindowResizerTextDirectionTest, DragReordersPanelsHorizontal) {
- if (!SupportsHostWindowResize())
- return;
-
DragAlongShelfReorder(base::i18n::IsRTL() ? 1 : -1, 0);
}
TEST_F(PanelWindowResizerTest, DragReordersPanelsVertical) {
- if (!SupportsHostWindowResize())
- return;
-
GetPrimaryShelf()->SetAlignment(SHELF_ALIGNMENT_LEFT);
DragAlongShelfReorder(0, -1);
}
@@ -494,9 +477,6 @@ TEST_F(PanelWindowResizerTest, DragReordersPanelsVertical) {
// Tests that panels can have transient children of different types.
// The transient children should be reparented in sync with the panel.
TEST_P(PanelWindowResizerTransientTest, PanelWithTransientChild) {
- if (!SupportsHostWindowResize())
- return;
-
std::unique_ptr<aura::Window> window(CreatePanelWindow(gfx::Point(0, 0)));
std::unique_ptr<aura::Window> child(
CreateTestWindowInShellWithDelegateAndType(
« no previous file with comments | « ash/wm/overview/window_selector_unittest.cc ('k') | ash/wm/window_positioner_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698