Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2370843003: Suborigin LayoutTest formatting and refactoring (Closed)

Created:
4 years, 2 months ago by jww
Modified:
4 years, 2 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suborigin LayoutTest formatting and refactoring This CL significantly cleans up and makes consistent the suborigin LayoutTests. It updates them to match the service worker style (https://www.chromium.org/blink/serviceworker/testing#TOC-Layout-Tests-Style) as best as possible. However, this does leave in place uses of the old js-test framework, leaving updating to testharness for a later exercise). R=mkwst@chromium.org Committed: https://crrev.com/e70a53228ef94fcf004916046caea0789c770a30 Cr-Commit-Position: refs/heads/master@{#421259}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1211 lines, -975 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cors-eventsource.php View 2 chunks +54 lines, -43 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cors-fetch.php View 2 chunks +45 lines, -37 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cors-fetch-failure-output.php View 1 chunk +36 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cors-fetch-failure-output-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cors-fetch-preflight.php View 2 chunks +67 lines, -53 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cors-font-face.php View 2 chunks +34 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cors-import.php View 2 chunks +26 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cors-script.php View 3 chunks +36 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cors-style.php View 2 chunks +29 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cors-xhr.php View 2 chunks +34 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cors-xhr-failure-output.php View 1 chunk +35 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cors-xhr-failure-output-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cors-xhr-preflight.php View 2 chunks +62 lines, -61 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cross-origin-script-window-onerror-cors.php View 1 chunk +26 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cross-origin-script-window-onerror-no-cors.php View 1 chunk +22 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cross-origin-window-event-exception.php View 1 chunk +22 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cross-origin-window-open-exception.php View 1 chunk +24 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cross-origin-worker-onerror-no-cors.php View 1 chunk +17 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/suborigins/multiple-suborigins-disallowed.php View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/suborigins/multiple-suborigins-disallowed-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/resources/child-changes-document-domain.php View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/resources/fetch-resource.php View 1 chunk +14 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/resources/iframe-reaches-into-parent.php View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/resources/post-document-cookie.php View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/resources/post-document-to-parent.php View 1 chunk +8 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/resources/post-to-parent.php View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/resources/reach-into-iframe.php View 1 chunk +13 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/resources/suborigin-cors-lib.js View 2 chunks +140 lines, -104 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-allow-same-suborigin-access.html View 2 chunks +33 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-blocked-different-suborigins.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-blocked-not-in-suborigin-to-suborigin.php View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-change-document-domain.html View 2 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-cookies.php View 2 chunks +51 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-cssRules.php View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-document-domain.php View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-document-suborigin.html View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-in-meta-disallowed.html View 1 chunk +22 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-in-meta-disallowed-console-warning.html View 1 chunk +8 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-in-meta-disallowed-console-warning-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-invalid-names.html View 1 chunk +26 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-invalid-options.html View 1 chunk +20 lines, -16 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-multiple-suborigins-disallowed.php View 1 chunk +7 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-multiple-suborigins-disallowed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-no-document-suborigin.html View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-postmessage.html View 1 chunk +19 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-service-worker-dom-access.php View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-service-worker-fetch-event.html View 2 chunks +25 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-service-worker-link-rel.php View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-service-worker-no-xorigin-caching.html View 1 chunk +27 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-storage-dom-access.php View 1 chunk +13 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-unsafe-cookies.php View 1 chunk +57 lines, -43 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-unsafe-postmessage-receive.php View 1 chunk +24 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-unsafe-postmessage-send.html View 1 chunk +24 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-valid-names.html View 1 chunk +20 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-valid-options.html View 1 chunk +24 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jww
Mike, this is all reformatting and refactoring of tests, with hopefully nothing new, so review ...
4 years, 2 months ago (2016-09-27 06:51:25 UTC) #1
Mike West
RS LGTM. I spot checked a few, and they looked reasonable. I'll trust you on ...
4 years, 2 months ago (2016-09-27 07:55:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370843003/1
4 years, 2 months ago (2016-09-27 17:49:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 17:56:37 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 17:59:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e70a53228ef94fcf004916046caea0789c770a30
Cr-Commit-Position: refs/heads/master@{#421259}

Powered by Google App Engine
This is Rietveld 408576698