third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cross-origin-script-window-onerror-cors.php - Issue 2370843003: Suborigin LayoutTest formatting and refactoring

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cross-origin-script-window-onerror-cors.php

Issue 2370843003: Suborigin LayoutTest formatting and refactoring (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cors-xhr-preflight.php ('k') | third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cross-origin-script-window-onerror-no-cors.php » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cross-origin-script-window-onerror-cors.php

diff --git a/third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cross-origin-script-window-onerror-cors.php b/third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cross-origin-script-window-onerror-cors.php

index a96edbb339a41edea838a3ae5192d3d41c630ba9..cbe183e166d3ac3c22e1ef52d68fda24f3aa7ef6 100644

--- a/third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cross-origin-script-window-onerror-cors.php

+++ b/third_party/WebKit/LayoutTests/http/tests/security/suborigins/crossorigin/suborigin-cross-origin-script-window-onerror-cors.php

@@ -3,27 +3,34 @@

<!DOCTYPE html>

<head>

+<meta charset="utf-8">

</head>

<body>

- <script src="/js-test-resources/js-test.js"></script>

- <script>

- window.jsTestIsAsync = true;

- description("The Test passes if 'window.onerror' gets unsanitized information about an exception thrown in a script loaded with a 'crossorigin' attribute, and delivered with valid CORS headers.");

+<script src="/js-test-resources/js-test.js"></script>

+<script>

+window.jsTestIsAsync = true;

+description(

+ 'The Test passes if \'window.onerror\' gets unsanitized information about ' +

+ 'an exception thrown in a script loaded with a \'crossorigin\' attribute, ' +

+ 'and delivered with valid CORS headers.');

- window.onerror = function(msg, url, line, column, error) {

- window.msg = msg;

- window.url = url;

- window.line = line;

- window.column = column;

- window.errorObject = error;

- shouldBeTrue("/SomeError/.test(msg)");

- shouldBeEqualToString("url", "http://127.0.0.1:8000/security/resources/cors-script.php?fail=true&cors=http-so://foobar.127.0.0.1:8000");

- shouldBe("line", "1");

- shouldBe("column", "1");

- shouldNotBe("window.errorObject", "null");

- finishJSTest();

- }

- </script>

- <script crossorigin src="/security/resources/cors-script.php?fail=true&cors=http-so://foobar.127.0.0.1:8000"></script>

+window.onerror = function(msg, url, line, column, error) {

+ window.msg = msg;

+ window.url = url;

+ window.line = line;

+ window.column = column;

+ window.errorObject = error;

+ shouldBeTrue('/SomeError/.test(msg)');

+ shouldBeEqualToString(

+ 'url',

+ 'http://127.0.0.1:8000/security/resources/cors-script.php?' +

+ 'fail=true&cors=http-so://foobar.127.0.0.1:8000');

+ shouldBe('line', '1');

+ shouldBe('column', '1');

+ shouldNotBe('window.errorObject', 'null');

+ finishJSTest();

+</script>

+<script crossorigin src="/security/resources/cors-script.php?fail=true&cors=http-so://foobar.127.0.0.1:8000"></script>

</body>

</html>