Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6151)

Unified Diff: chrome/browser/resources/settings/site_settings/site_data.js

Issue 2370843002: Site Settings Desktop: Only show Remove action if filter hasn't removed all. (Closed)
Patch Set: Address feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_data.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/site_data.js
diff --git a/chrome/browser/resources/settings/site_settings/site_data.js b/chrome/browser/resources/settings/site_settings/site_data.js
index 116ad3dfcd074c2dbd02a82cee564c8adef9f595..b8657741880ff287e851a0005288ae567fbe1a49 100644
--- a/chrome/browser/resources/settings/site_settings/site_data.js
+++ b/chrome/browser/resources/settings/site_settings/site_data.js
@@ -76,14 +76,9 @@ Polymer({
this.$.list.render();
},
- /**
- * Returns whether remove all should be shown.
- * @param {!Array<!CookieDataSummaryItem>} sites The sites list to use to
- * determine whether the button should be visible.
- * @private
- */
- removeAllIsVisible_: function(sites) {
- return sites.length > 0;
+ /** @private */
+ isRemoveButtonVisible_: function(sites, renderedItemCount) {
+ return renderedItemCount != 0;
},
/**
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_data.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698