Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3976)

Unified Diff: chrome/browser/resources/settings/site_settings/site_data.html

Issue 2370843002: Site Settings Desktop: Only show Remove action if filter hasn't removed all. (Closed)
Patch Set: Address feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/site_settings/site_data.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/site_data.html
diff --git a/chrome/browser/resources/settings/site_settings/site_data.html b/chrome/browser/resources/settings/site_settings/site_data.html
index 09f38e49acda734032ca177c4d26c4c98d0636c3..2d95ea9c9c18d287b8be050d997c871d45c3aa53 100644
--- a/chrome/browser/resources/settings/site_settings/site_data.html
+++ b/chrome/browser/resources/settings/site_settings/site_data.html
@@ -36,7 +36,8 @@
</style>
<div class="layout horizontal">
<div class="flex site-header">$i18n{siteSettingsCookieHeader}</div>
- <div class="secondary-action" hidden$="[[!removeAllIsVisible_(sites)]]">
+ <div class="secondary-action"
+ hidden$="[[!isRemoveButtonVisible_(sites, renderedItemCount)]]">
<paper-button on-tap="onDeleteMultipleSites_" class="secondary-button">
[[computeRemoveLabel_(filterString_)]]
</paper-button>
@@ -47,7 +48,8 @@
</div>
<div class="list-frame vertical-list">
- <template is="dom-repeat" id="list" items="[[sites]]" filter="showItem_">
+ <template is="dom-repeat" id="list" items="[[sites]]" filter="showItem_"
+ rendered-item-count="{{renderedItemCount}}">
<div class="list-item layout horizontal">
<div class="layout horizontal flex" on-tap="onSiteTap_" actionable>
<div class="favicon-image site"
@@ -61,7 +63,6 @@
</div>
</template>
</div>
-
</template>
<script src="cookie_info.js"></script>
<script src="cookie_tree_node.js"></script>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/site_settings/site_data.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698