Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 23708025: Clear TemplateContentDocumentFragment::m_host when HTMLTemplateElement is destroyed (Closed)

Created:
7 years, 3 months ago by adamk
Modified:
7 years, 3 months ago
Reviewers:
inferno
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Clear TemplateContentDocumentFragment::m_host when HTMLTemplateElement is destroyed Note that the included test only crashes reliably in an asan build. R=inferno@chromium.org BUG=286975 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157543

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix double-gc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
A LayoutTests/fast/dom/HTMLTemplateElement/content-outlives-template-crash.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLTemplateElement/content-outlives-template-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/dom/TemplateContentDocumentFragment.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLTemplateElement.h View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTemplateElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
adamk
7 years, 3 months ago (2013-09-10 00:38:02 UTC) #1
inferno
lgtm with nits https://codereview.chromium.org/23708025/diff/1/LayoutTests/fast/dom/HTMLTemplateElement/content-outlives-template-crash.html File LayoutTests/fast/dom/HTMLTemplateElement/content-outlives-template-crash.html (right): https://codereview.chromium.org/23708025/diff/1/LayoutTests/fast/dom/HTMLTemplateElement/content-outlives-template-crash.html#newcode10 LayoutTests/fast/dom/HTMLTemplateElement/content-outlives-template-crash.html:10: gc(); nit: gc() is copied twice. ...
7 years, 3 months ago (2013-09-10 00:57:43 UTC) #2
inferno
7 years, 3 months ago (2013-09-10 03:02:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/23708025/9001
7 years, 3 months ago (2013-09-10 17:34:04 UTC) #4
adamk
https://codereview.chromium.org/23708025/diff/1/Source/core/html/HTMLTemplateElement.h File Source/core/html/HTMLTemplateElement.h (right): https://codereview.chromium.org/23708025/diff/1/Source/core/html/HTMLTemplateElement.h#newcode46 Source/core/html/HTMLTemplateElement.h:46: DocumentFragment* content() const; On 2013/09/10 00:57:43, inferno wrote: > ...
7 years, 3 months ago (2013-09-10 17:34:12 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 18:50:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/23708025/9001
7 years, 3 months ago (2013-09-10 19:35:01 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 20:36:06 UTC) #8
Message was sent while issue was closed.
Change committed as 157543

Powered by Google App Engine
This is Rietveld 408576698