Source/core/dom/TemplateContentDocumentFragment.h - Issue 23708025: Clear TemplateContentDocumentFragment::m_host when HTMLTemplateElement is destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/TemplateContentDocumentFragment.h

Issue 23708025: Clear TemplateContentDocumentFragment::m_host when HTMLTemplateElement is destroyed (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix double-gc Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLTemplateElement/content-outlives-template-crash-expected.txt ('k') | Source/core/html/HTMLTemplateElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/TemplateContentDocumentFragment.h

diff --git a/Source/core/dom/TemplateContentDocumentFragment.h b/Source/core/dom/TemplateContentDocumentFragment.h

index b2023d0d1255e71fb814856ac4a283f11b02fbdc..6c44e6075eea706843dffeacce91ecec4a06951d 100644

--- a/Source/core/dom/TemplateContentDocumentFragment.h

+++ b/Source/core/dom/TemplateContentDocumentFragment.h

@@ -39,6 +39,7 @@ public:

}

const Element* host() const { return m_host; }

+ void clearHost() { m_host = 0; }

private:

TemplateContentDocumentFragment(Document& document, const Element* host)