third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h - Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)

Patch Set: Renamed members Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutTableSection.cpp ('K') | « third_party/WebKit/Source/core/layout/TextAutosizer.cpp ('k') | third_party/WebKit/Source/core/layout/line/InlineFlowBox.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

diff --git a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

index c8f2fc65a6464cb5c05d6c2939e0843005a2401c..e366c4fc71aa0bd9e87bd1316e02dac373301039 100644

--- a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

+++ b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

@@ -377,7 +377,7 @@ inline void BreakingContext::handleOutOfFlowPositioned(Vector<LineLayoutBox>& po

if (!isInlineType) {

m_block.setStaticInlinePositionForChild(box, m_block.startOffsetForContent());

} else {

- // If our original display was an INLINE type, then we can determine our static y position

+ // If our original display was an EDisplay::Inline type, then we can determine our static y position

alancutter (OOO until 2018) 2016/09/26 04:23:47 This should not change.

// now. Note, however, that if we're paginated, we may have to update this position after

// the line has been laid out, since the line may be pushed by a pagination strut.

box.layer()->setStaticBlockPosition(m_block.logicalHeight());