third_party/WebKit/Source/core/layout/LayoutTableSection.cpp - Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)

Patch Set: Renamed members Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/Source/core/layout/LayoutObject.h ('K') | « third_party/WebKit/Source/core/layout/LayoutTableRow.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTextControlMultiLine.cpp » ('j') | third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

index 2edd3bc3d5ce3847941bc9e303c3a86110b3a4ca..c04bdfd60287577d1db2a4fb53f6a087e48cc6ed 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

@@ -119,7 +119,7 @@ LayoutTableSection::~LayoutTableSection()

void LayoutTableSection::styleDidChange(StyleDifference diff, const ComputedStyle* oldStyle)

{

- DCHECK(style()->display() == TABLE_FOOTER_GROUP || style()->display() == TABLE_ROW_GROUP || style()->display() == TABLE_HEADER_GROUP);

+ DCHECK(style()->display() == EDisplay::TableFooterGroup || style()->display() == EDisplay::TableRowGroup || style()->display() == EDisplay::TableHeaderGroup);

LayoutTableBoxComponent::styleDidChange(diff, oldStyle);

propagateStyleToAnonymousChildren();

@@ -262,10 +262,10 @@ void LayoutTableSection::addCell(LayoutTableCell* cell, LayoutTableRow* row)

// ### mozilla still seems to do the old HTML way, even for strict DTD

// (see the annotation on table cell layouting in the CSS specs and the testcase below:

- // <TABLE border>

+ // <EDisplay::Table border>

// <TR><TD>1 <TD rowspan="2">2 <TD>3 <TD>4

// <TR><TD colspan="2">5

- // </TABLE>

alancutter (OOO until 2018) 2016/09/26 04:23:47 This should not change.

sashab 2016/09/26 04:48:39 Ahahah this has to be my favourite accidental chan

+ // </EDisplay::Table>

while (m_cCol < nCols && (cellAt(insertionRow, m_cCol).hasCells() || cellAt(insertionRow, m_cCol).inColSpan))

m_cCol++;

@@ -1696,7 +1696,7 @@ bool LayoutTableSection::nodeAtPoint(HitTestResult& result, const HitTestLocatio

LayoutTableSection* LayoutTableSection::createAnonymousWithParent(const LayoutObject* parent)

{

- RefPtr<ComputedStyle> newStyle = ComputedStyle::createAnonymousStyleWithDisplay(parent->styleRef(), TABLE_ROW_GROUP);

+ RefPtr<ComputedStyle> newStyle = ComputedStyle::createAnonymousStyleWithDisplay(parent->styleRef(), EDisplay::TableRowGroup);

LayoutTableSection* newSection = new LayoutTableSection(nullptr);

newSection->setDocumentForAnonymous(&parent->document());

newSection->setStyle(newStyle.release());