Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)
Patch Set: Renamed members Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h
index fbae05d1ec8f3245ae07a2b12ffb5083661d061d..1db59c451e2391c7e62e97bc563a0d6c0b5533ec 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.h
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h
@@ -644,9 +644,9 @@ public:
{
// This function is kept in sync with anonymous block creation conditions in
// LayoutBlock::createAnonymousBlock(). This includes creating an anonymous
- // LayoutBlock having a BLOCK or BOX display. Other classes such as LayoutTextFragment
alancutter (OOO until 2018) 2016/09/26 04:23:47 This probably should not change.
+ // LayoutBlock having a EDisplay::Block or EDisplay::Box display. Other classes such as LayoutTextFragment
// are not LayoutBlocks and will return false. See https://bugs.webkit.org/show_bug.cgi?id=56709.
- return isAnonymous() && (style()->display() == BLOCK || style()->display() == BOX) && style()->styleType() == PseudoIdNone && isLayoutBlock() && !isListMarker() && !isLayoutFlowThread() && !isLayoutMultiColumnSet()
+ return isAnonymous() && (style()->display() == EDisplay::Block || style()->display() == EDisplay::Box) && style()->styleType() == PseudoIdNone && isLayoutBlock() && !isListMarker() && !isLayoutFlowThread() && !isLayoutMultiColumnSet()
&& !isLayoutFullScreen()
&& !isLayoutFullScreenPlaceholder();
}

Powered by Google App Engine
This is Rietveld 408576698