Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 237063003: Add StrictTypeChecking to CRC2D ImageData APIs (Closed)

Created:
6 years, 8 months ago by fs
Modified:
6 years, 8 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, arv+blink, dglazkov+blink, Rik, adamk+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Add StrictTypeChecking to CRC2D ImageData APIs This moves the null-check out into generated bindings code. The test canvas/philip/tests/2d.imageData.create1.zero.html is (minimally) adjusted to match the revised upstream WPT test. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171484

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -19 lines) Patch
M LayoutTests/canvas/philip/tests/2d.imageData.create1.zero.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-createImageData-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 2 chunks +2 lines, -13 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fs
Sorry for the CL-bombing Justin =)
6 years, 8 months ago (2014-04-14 14:32:51 UTC) #1
Justin Novosad
No problem. I agree with making this change in many small chunks like this. lgtm
6 years, 8 months ago (2014-04-14 14:39:32 UTC) #2
fs
The CQ bit was checked by fs@opera.com
6 years, 8 months ago (2014-04-14 16:38:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/237063003/20001
6 years, 8 months ago (2014-04-14 16:38:28 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 17:10:49 UTC) #5
Message was sent while issue was closed.
Change committed as 171484

Powered by Google App Engine
This is Rietveld 408576698