Issue 237063003: Add StrictTypeChecking to CRC2D ImageData APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 237063003: Add StrictTypeChecking to CRC2D ImageData APIs (Closed)

Created:
6 years, 8 months ago by fs

Modified:
6 years, 8 months ago

Reviewers:
Justin Novosad

CC:
blink-reviews, arv+blink, dglazkov+blink, Rik, adamk+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add StrictTypeChecking to CRC2D ImageData APIs This moves the null-check out into generated bindings code. The test canvas/philip/tests/2d.imageData.create1.zero.html is (minimally) adjusted to match the revised upstream WPT test. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171484

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -19 lines)			Patch
M	LayoutTests/canvas/philip/tests/2d.imageData.create1.zero.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/canvas/canvas-createImageData-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/canvas/CanvasRenderingContext2D.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/canvas/CanvasRenderingContext2D.cpp	View	1	2 chunks	+2 lines, -13 lines	0 comments	Download
M	Source/core/html/canvas/CanvasRenderingContext2D.idl	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Justin Novosad

No problem. I agree with making this change in many small chunks like this. lgtm

6 years, 8 months ago (2014-04-14 14:39:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/237063003/20001

6 years, 8 months ago (2014-04-14 16:38:28 UTC) #4

Message was sent while issue was closed.

Change committed as 171484

Expand Messages | Collapse Messages