Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2370623002:
Allow for re-entrance in the notification manager. (Closed)
|
Created:
4 years, 2 months ago by Avi (use Gerrit) Modified:
4 years, 2 months ago CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAllow for re-entrance in the notification manager.
BUG=649971, 555865
TEST=crashes stop
Committed: https://crrev.com/281bb8ae00ff93fa2b61d9c6ad1ce2fcefff5dfc
Cr-Commit-Position: refs/heads/master@{#420929}
Patch Set 1 #Patch Set 2 : use the iterator #Messages
Total messages: 26 (21 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
avi@chromium.org changed reviewers: + stevenjb@chromium.org, thakis@chromium.org
Steven/Nico: a crash fix for my removal of stl_util...
Description was changed from ========== Allow for re-entrance in the notification manager. BUG=649971 TEST=crashes stop ========== to ========== Allow for re-entrance in the notification manager. BUG=649971,555865 TEST=crashes stop ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
I'm a little surprised / concerned that the browser immediately shuts itself down instead of deferring it, but I'm not about to get involved in that discussion :) LGTM
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Allow for re-entrance in the notification manager. BUG=649971,555865 TEST=crashes stop ========== to ========== Allow for re-entrance in the notification manager. BUG=649971,555865 TEST=crashes stop ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Allow for re-entrance in the notification manager. BUG=649971,555865 TEST=crashes stop ========== to ========== Allow for re-entrance in the notification manager. BUG=649971,555865 TEST=crashes stop Committed: https://crrev.com/281bb8ae00ff93fa2b61d9c6ad1ce2fcefff5dfc Cr-Commit-Position: refs/heads/master@{#420929} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/281bb8ae00ff93fa2b61d9c6ad1ce2fcefff5dfc Cr-Commit-Position: refs/heads/master@{#420929} |
