Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Issue 23704009: Adding decorations(icons) in right order to omnibox (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
index 441e8f02277ddfd74a9c3a88417bc646ecf3d262..87c9b7c1b848e727a98880b097a6333392130f4a 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
@@ -660,7 +660,9 @@ void LocationBarViewMac::Layout() {
for (size_t i = 0; i < page_action_decorations_.size(); ++i) {
[cell addRightDecoration:page_action_decorations_[i]];
}
- for (size_t i = 0; i < content_setting_decorations_.size(); ++i) {
+
+ // Reverse iterating through |content_setting_decoration_| as in aura
Ilya Sherman 2013/09/14 04:01:32 nit: "Iterate through |content_setting_decorations
npentrel 2013/09/17 11:13:22 Done.
+ for (int i = content_setting_decorations_.size()-1; i >= 0; --i) {
Ilya Sherman 2013/09/14 04:01:32 nit: Please use rbegin() and rend() for iterating
npentrel 2013/09/17 11:13:22 Done.
[cell addRightDecoration:content_setting_decorations_[i]];
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698