Adding decorations(icons) in right order to omnibox

chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_service.h"
@@ skipping 642 matching lines @@
   [cell addLeftDecoration:location_icon_decoration_.get()];
   [cell addLeftDecoration:selected_keyword_decoration_.get()];
   [cell addLeftDecoration:ev_bubble_decoration_.get()];
   [cell addRightDecoration:star_decoration_.get()];
   [cell addRightDecoration:zoom_decoration_.get()];
 
   // Note that display order is right to left.
   for (size_t i = 0; i < page_action_decorations_.size(); ++i) {
     [cell addRightDecoration:page_action_decorations_[i]];
   }
-  for (size_t i = 0; i < content_setting_decorations_.size(); ++i) {
+
+  // Reverse iterating through |content_setting_decoration_| as in aura

[Ilya Sherman, 2013/09/14 04:01:32]

nit: "Iterate through |content_setting_decorations_| in reverse order so that
the order in which the decorations are drawn matches the Views code."

[npentrel, 2013/09/17 11:13:22]

Done.

+  for (int i = content_setting_decorations_.size()-1; i >= 0; --i) {

[Ilya Sherman, 2013/09/14 04:01:32]

nit: Please use rbegin() and rend() for iterating through the vector.  Or, if
you really prefer to keep the index variable, add spaces around the minus sign
in "content_setting_decorations_.size()-1".

[npentrel, 2013/09/17 11:13:22]

Done.

     [cell addRightDecoration:content_setting_decorations_[i]];
   }
 
   [cell addRightDecoration:keyword_hint_decoration_.get()];
   [cell addRightDecoration:mic_search_decoration_.get()];
 
   // By default only the location icon is visible.
   location_icon_decoration_->SetVisible(true);
   selected_keyword_decoration_->SetVisible(false);
   ev_bubble_decoration_->SetVisible(false);
@@ skipping 64 matching lines @@
 }
 
 bool LocationBarViewMac::UpdateMicSearchDecorationVisibility() {
   bool is_visible = !GetToolbarModel()->input_in_progress() &&
                     browser_->search_model()->voice_search_supported();
   if (mic_search_decoration_->IsVisible() == is_visible)
     return false;
   mic_search_decoration_->SetVisible(is_visible);
   return true;
 }