Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Unified Diff: blimp/engine/feature/engine_render_widget_feature.cc

Issue 2370393002: Extracting placeholder information from Webkit to Blimp (Closed)
Patch Set: Extracting info through RHVW Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/feature/engine_render_widget_feature.cc
diff --git a/blimp/engine/feature/engine_render_widget_feature.cc b/blimp/engine/feature/engine_render_widget_feature.cc
index 611427d10f003210b1aa1a1a3b73bf14b48ed528..7381617244208e242bf99f9c38e5cf14da453bf4 100644
--- a/blimp/engine/feature/engine_render_widget_feature.cc
+++ b/blimp/engine/feature/engine_render_widget_feature.cc
@@ -135,9 +135,9 @@ void EngineRenderWidgetFeature::SendCompositorMessage(
void EngineRenderWidgetFeature::SendShowImeRequest(
const int tab_id,
content::RenderWidgetHost* render_widget_host,
- const ui::TextInputClient* client) {
- DCHECK(client);
-
+ ui::TextInputType type,
+ const std::string& text,
+ const std::string& placeholder) {
David Trainor- moved to gerrit 2016/10/26 01:36:42 Do we want to add this to the proto as well?
shaktisahu 2016/10/31 23:13:58 Yes. I will add it in a subsequent CL for blimp ch
ImeMessage* ime_message;
std::unique_ptr<BlimpMessage> blimp_message =
CreateBlimpMessage(&ime_message, tab_id);
@@ -147,13 +147,8 @@ void EngineRenderWidgetFeature::SendShowImeRequest(
ime_message->set_render_widget_id(render_widget_id);
ime_message->set_type(ImeMessage::SHOW_IME);
ime_message->set_text_input_type(
- InputMessageConverter::TextInputTypeToProto(client->GetTextInputType()));
-
- gfx::Range text_range;
- base::string16 existing_text;
- client->GetTextRange(&text_range);
- client->GetTextFromRange(text_range, &existing_text);
- ime_message->set_ime_text(base::UTF16ToUTF8(existing_text));
+ InputMessageConverter::TextInputTypeToProto(type));
+ ime_message->set_ime_text(text);
ime_message_sender_->ProcessMessage(std::move(blimp_message),
net::CompletionCallback());

Powered by Google App Engine
This is Rietveld 408576698