Extracting placeholder information from Webkit to Blimp

blimp/engine/feature/engine_render_widget_feature.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/engine/feature/engine_render_widget_feature.h"
 
 #include "base/numerics/safe_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "blimp/common/create_blimp_message.h"
 #include "blimp/common/proto/blimp_message.pb.h"
@@ skipping 117 matching lines @@
   compositor_message->set_payload(message.data(),
                                   base::checked_cast<int>(message.size()));
 
   compositor_message_sender_->ProcessMessage(std::move(blimp_message),
                                                 net::CompletionCallback());
 }
 
 void EngineRenderWidgetFeature::SendShowImeRequest(
     const int tab_id,
     content::RenderWidgetHost* render_widget_host,
-    const ui::TextInputClient* client) {
-  DCHECK(client);
-
+    ui::TextInputType type,
+    const std::string& text,
+    const std::string& placeholder) {

[David Trainor- moved to gerrit, 2016/10/26 01:36:42]

Do we want to add this to the proto as well?

[shaktisahu, 2016/10/31 23:13:58]

Yes. I will add it in a subsequent CL for blimp changes.

   ImeMessage* ime_message;
   std::unique_ptr<BlimpMessage> blimp_message =
       CreateBlimpMessage(&ime_message, tab_id);
 
   int render_widget_id = GetRenderWidgetId(tab_id, render_widget_host);
   DCHECK_GT(render_widget_id, 0);
   ime_message->set_render_widget_id(render_widget_id);
   ime_message->set_type(ImeMessage::SHOW_IME);
   ime_message->set_text_input_type(
-      InputMessageConverter::TextInputTypeToProto(client->GetTextInputType()));
-
-  gfx::Range text_range;
-  base::string16 existing_text;
-  client->GetTextRange(&text_range);
-  client->GetTextFromRange(text_range, &existing_text);
-  ime_message->set_ime_text(base::UTF16ToUTF8(existing_text));
+      InputMessageConverter::TextInputTypeToProto(type));
+  ime_message->set_ime_text(text);
 
   ime_message_sender_->ProcessMessage(std::move(blimp_message),
                                       net::CompletionCallback());
 }
 
 void EngineRenderWidgetFeature::SendHideImeRequest(
     const int tab_id,
     content::RenderWidgetHost* render_widget_host) {
   ImeMessage* ime_message;
   std::unique_ptr<BlimpMessage> blimp_message =
@@ skipping 219 matching lines @@
   IdToRenderWidgetMap::const_iterator widget_id_it =
       id_to_render_widget->find(render_widget_id);
   if (widget_id_it == id_to_render_widget->end())
     return nullptr;
 
   return widget_id_it->second;
 }
 
 }  // namespace engine
 }  // namespace blimp