Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1931)

Unified Diff: blimp/engine/session/blimp_engine_session.cc

Issue 2370393002: Extracting placeholder information from Webkit to Blimp (Closed)
Patch Set: dtrainor comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/session/blimp_engine_session.cc
diff --git a/blimp/engine/session/blimp_engine_session.cc b/blimp/engine/session/blimp_engine_session.cc
index f4708eaa662112f412ca279c403249b77864a06e..3631761e56d7494969b2112680de4d4c7754234d 100644
--- a/blimp/engine/session/blimp_engine_session.cc
+++ b/blimp/engine/session/blimp_engine_session.cc
@@ -402,14 +402,11 @@ void BlimpEngineSession::OnTextInputStateChanged(
ui::TextInputType type =
client ? client->GetTextInputType() : ui::TEXT_INPUT_TYPE_NONE;
- // TODO(shaktisahu): Propagate the new type to the client.
// Hide IME, when text input is out of focus, i.e. if the text input type
// changes to ui::TEXT_INPUT_TYPE_NONE. For other text input types,
// OnShowImeIfNeeded is used instead to send show IME request to client.
if (type == ui::TEXT_INPUT_TYPE_NONE)
- render_widget_feature_.SendHideImeRequest(
- tab_->tab_id(),
- tab_->web_contents()->GetRenderWidgetHostView()->GetRenderWidgetHost());
+ tab_->HideIme();
}
void BlimpEngineSession::OnInputMethodDestroyed(
@@ -422,10 +419,7 @@ void BlimpEngineSession::OnShowImeIfNeeded() {
!window_tree_host_->GetInputMethod()->GetTextInputClient())
return;
- render_widget_feature_.SendShowImeRequest(
- tab_->tab_id(),
- tab_->web_contents()->GetRenderWidgetHostView()->GetRenderWidgetHost(),
- window_tree_host_->GetInputMethod()->GetTextInputClient());
+ tab_->ShowIme();
}
void BlimpEngineSession::ProcessMessage(

Powered by Google App Engine
This is Rietveld 408576698