Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: blimp/engine/feature/engine_render_widget_feature_unittest.cc

Issue 2370393002: Extracting placeholder information from Webkit to Blimp (Closed)
Patch Set: dtrainor comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/feature/engine_render_widget_feature_unittest.cc
diff --git a/blimp/engine/feature/engine_render_widget_feature_unittest.cc b/blimp/engine/feature/engine_render_widget_feature_unittest.cc
index 4c8ae6d853909791aa7acfe6b1e4def0c4c9e021..bd27305a23c90e0e9e23044a5d368e3bb5280c7b 100644
--- a/blimp/engine/feature/engine_render_widget_feature_unittest.cc
+++ b/blimp/engine/feature/engine_render_widget_feature_unittest.cc
@@ -17,6 +17,7 @@
#include "blimp/net/input_message_generator.h"
#include "blimp/net/test_common.h"
#include "content/public/browser/render_widget_host.h"
+#include "content/public/common/form_field_data.h"
#include "net/base/net_errors.h"
#include "net/base/test_completion_callback.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -264,8 +265,13 @@ TEST_F(EngineRenderWidgetFeatureTest, ImeRequestSentCorrectly) {
*ime_message_sender_,
MockableProcessMessage(BlimpImeMsgEquals(2, ImeMessage::HIDE_IME), _));
+ content::FormFieldData field;
+ field.text = "green apple";
+ field.placeholder = "fruit name";
+ field.text_input_type = ui::TEXT_INPUT_TYPE_TEXT;
+
feature_.OnRenderWidgetCreated(2, &render_widget_host1_);
- feature_.SendShowImeRequest(2, &render_widget_host1_, &text_input_client_);
+ feature_.SendShowImeRequest(2, &render_widget_host1_, field);
feature_.SendHideImeRequest(2, &render_widget_host1_);
}

Powered by Google App Engine
This is Rietveld 408576698